search

yugabyte / yugabyte-operator

Kubernetes Operator for YugabyteDB (legacy)
65 stars 29 forks source link

allowing storageclass to be used from config #6

Closed svanellewee closed 4 years ago

svanellewee commented 4 years ago

Good day! Sorry if I'm not following the correct process, the contribution doc doesn't specify how to provide code changes.

Myself and @nvulane have been testing this and found that the storageClass yaml configs are not being used. This PR is to allow for that. Other than that I just want to say this is a great db to work with!

Best regards, Stephan and Nvulane.

rkarthik007 commented 4 years ago

Hi @svanellewee

Glad you like YugabyteDB! Please do let us know if you build a cool app on top or run a benchmark, would love to showcase your work!

Also, thanks to both you and Nvulane for your contribution! Could you both please add yourselves to the YugabyteDB contributor list: https://github.com/yugabyte/yugabyte-db/blob/master/CONTRIBUTORS.md

I have added a couple of folks as reviewers, they can help take this forward.

svanellewee commented 4 years ago

Will do @rkarthik007 ! Sorry for the long delay. Will add there. Also have added go mod changes and a removal of a silly line in the tests.

ramkumarvs commented 4 years ago

@svanellewee merged your changes. Thanks for the contribution!

svanellewee commented 4 years ago

Glad to help! Best of luck peeps!