Dynamic height doesn't work

[GoogleCodeExporter]

Found in Release:
gwt-gadgets-trunk

Detailed description:
In attachment there a simple gadgets implementing NeedsDynamicHeight, 
showing that the adjustHeight() method doesn't work properly. You can try 
to load the gadget in iGoogle click many times the button "Click me" when 
the gadget's height exceeds click the resize button. The result of this is 
nothing.

Original issue reported on code.google.com by daniele.galdi@gmail.com on 27 Nov 2008 at 11:44

Attachments:

• SimpleGadget.zip

[GoogleCodeExporter]

Original comment by galgwt.reviews@gmail.com on 27 Nov 2008 at 12:56

• Added labels: API-Gadgets

[GoogleCodeExporter]

If you use the provided patch and instead of use 

- RootPanel.get().add(gadget)

you use 

- RootPanel.get("__gadget_panel").add(gadget)

the gadget will be resized correctly.

Best Regards
Daniele

Original comment by daniele.galdi@gmail.com on 8 Jan 2009 at 8:06

Attachments:

• dynamic-height-doesnt-works.diff

[GoogleCodeExporter]

Original comment by galgwt.reviews@gmail.com on 8 Jan 2009 at 8:33

• Changed state: Accepted

[GoogleCodeExporter]

Hello Daniele,

ould you fill out a CLA so we can incorporate your change?

http://code.google.com/webtoolkit/makinggwtbetter.html#contributingcode

Thanks,
-Eric.

Original comment by galgwt.reviews@gmail.com on 9 Jan 2009 at 5:08

[GoogleCodeExporter]

Original comment by galgwt.reviews@gmail.com on 9 Jan 2009 at 5:09

• Changed state: Started

[GoogleCodeExporter]

I added a method to fetch the div and changed the 'id' 

The proposed change is up for review at:
  http://galgwt-reviews.appspot.com/2404

Original comment by galgwt.reviews@gmail.com on 9 Jan 2009 at 5:34

• Changed state: ReviewPending

[GoogleCodeExporter]

I added a method to retrieve the DIV as a part of the patch.

Proposed solution up for review at:

  http://galgwt-reviews.appspot.com/2404

Original comment by galgwt.reviews@gmail.com on 9 Jan 2009 at 5:59

[GoogleCodeExporter]

First of all thanks for reviewing my patch.

The new way to attach a gadget to a special div, shouldn't be the ONLY one. It 
easier to have a standard way to attach a gadget instead of two. The method you 
proposed can be included in the Gadget class.
And in the future this can prevent some problems like this.

Best Regards
Daniele

Original comment by daniele.galdi@gmail.com on 9 Jan 2009 at 6:46

[GoogleCodeExporter]

Interesting suggestion.  However, I feel weird about telling everyone to go 
through
this interface to attach their gadget UI to, when most GWT developers are used 
to
using RootPanel.get().  There really is no good reason to do otherwise unless 
you are
using the Resize feature.  If you want to explore it further, start a thread on 
the
GWT-Google-Api group and we'll discuss it.

Nicolas gave the LGTM and I committed the patch as r1171.

Original comment by galgwt.reviews@gmail.com on 23 Jan 2009 at 12:42

• Changed state: FixedNotReleased

[GoogleCodeExporter]

Released in gwt-gadgets-1.0.2

Original comment by galgwt.reviews@gmail.com on 21 Feb 2009 at 1:32

• Changed state: Fixed

[GoogleCodeExporter]

Updating account names

Original comment by zundel@google.com on 21 Dec 2009 at 2:00