search

yugalatea / gwt-google-apis

Automatically exported from code.google.com/p/gwt-google-apis
0 stars 0 forks source link

Add support for gadget pubsub (missing user pref attributes) #233

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Gadget pubsub needs to be able to set additional user pref attributes
defined at http://code.google.com/apis/gadgets/docs/pubsub.html:
  listen
  onchange
  publish
  group

Also, there are other user prefs which are missing as well defined at
http://code.google.com/apis/gadgets/docs/reference.html#Userprefs_Ref.  The
most obvious is the "required" attribute.

Original issue reported on code.google.com by bmcc...@google.com on 19 Jan 2009 at 1:24

GoogleCodeExporter commented 9 years ago

Original comment by galgwt.reviews@gmail.com on 20 Jan 2009 at 11:11

GoogleCodeExporter commented 9 years ago 
Gadget pubsub api is now deprecated, so we wont' be adding it.

I'll open a new ticket for other gadgets features to be updated.

Original comment by zundel@google.com on 19 Jun 2010 at 3:06

GoogleCodeExporter commented 9 years ago 
Has it been deprecated in favor of another API or does this functionality just 
not exist anymore?

Original comment by bmcc...@google.com on 19 Jun 2010 at 5:20

GoogleCodeExporter commented 9 years ago 
Sorry, it is still there, but under the new gadgets.pubsub namespace.

Original comment by zundel@google.com on 22 Jun 2010 at 11:04

GoogleCodeExporter commented 9 years ago 
I created a patch for this, but was unable to verify that this change works in 
a production setting in the 2 environments we're targeting for this release.

 - Orkut doesn't allow more than one gadget per page, so I'm not sure how to exercise pubsub if it works.
 - iGoogle currently does not support pubsub (even thought it is documented on their docs pages.)  I get JS exceptions and have found some forum posts and codesite issues referencing the problem:

  http://code.google.com/p/igoogle-legacy/issues/detail?id=202

If someone can take this patch and verify that it does the right thing on some 
Gadget container that does support pubsub, I will be happy to incorporate it.

Original comment by zundel@google.com on 23 Jun 2010 at 1:05

Attachments:

GoogleCodeExporter commented 9 years ago 
I would test it out, but we killed off gadget support from our project between 
now and when we requested this way back.

Original comment by bmcc...@google.com on 23 Jun 2010 at 4:17

GoogleCodeExporter commented 9 years ago 
Turns out PubSubFeature has a bug in the patch above - it defines only one 
argument in the js closure in the JSNI subscribe method, when there should 
actually be two arguments (caller, message)

Original comment by zundel@google.com on 21 Apr 2011 at 2:50

GoogleCodeExporter commented 9 years ago 
Review up at:

http://gwt-code-reviews.appspot.com/1421804/

Original comment by zundel@google.com on 22 Apr 2011 at 8:12

GoogleCodeExporter commented 9 years ago 
r1886

Original comment by zundel@google.com on 22 Apr 2011 at 10:49

GoogleCodeExporter commented 9 years ago

Original comment by zundel@google.com on 28 Oct 2011 at 3:43