yuhangwang / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Complete list of copy types in PBXCopyFilesBuildPhase support in xcode.py #429

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The list of copy types in PBXCopyFilesBuildPhase.path_tree_to_subfolder in the 
xcode generator has only a single entry corresponding to 'Products Directory'. 
I need to copy a framework to my app bundle which required supporting also the 
Frameworks copy type. So I completed the list of copy types.

The attached patch for xcode.py adds all these copy types. Please merge it to 
the master source. As the Apple documentation about build settings is 4 years 
old, I found all the information by testing with Xcode and grepping for strings 
in its sources.

Original issue reported on code.google.com by callow.m...@artspark.co.jp on 22 May 2014 at 10:03

GoogleCodeExporter commented 9 years ago
This is a very simple patch for xcodeproj_file.py. Please integrate it.

Original comment by callow.m...@artspark.co.jp on 3 Jun 2014 at 10:34

GoogleCodeExporter commented 9 years ago
I looked at adding a test for these additions to the PBXCopyFilesBuildPhase but 
there isn't a test of use of the existing "BUILT_PRODUCTS_DIR" entry that I 
could build on. In the current tests BUILT_PRODUCTS_DIR is only used as the 
destination of a 'cp' command in various actions. Another issue I couldn't 
figure out is how to give test.built_file_must_exist() the name of the 
destination to check. Xcode seems to have a mind of its own when it comes to 
build destinations plus the Xcode environment variable values differ across Mac 
& iOS.

If someone would give me an idea how to proceed I could take a crack at a test.

I'd really like to get these additions into the source so I can go back to 
having an external reference in our SVN tree.

Original comment by callow.m...@artspark.co.jp on 11 Jun 2014 at 3:59

GoogleCodeExporter commented 9 years ago
Here is an updated patch. I have also uploaded the changes to 
https://codereview.chromium.org/391223002/ for hopefully a faster response than 
here.

Original comment by callow.m...@artspark.co.jp on 25 Jul 2014 at 2:01

Attachments: