search

yuhangwang / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Makefile generator incorrectly creates LD_LIBRARY_PATH #470

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
In V8:

wingo@rusty:~/src/v8$ make x64.debug V=1
make[1]: Entering directory '/hack/v8/out'
  LD_LIBRARY_PATH=/hack/v8/out/x64.debug/lib.host:/hack/v8/out/x64.debug/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/gyp; mkdir -p /hack/v8/out/x64.debug/obj.target/v8_snapshot/geni; "/hack/v8/out/x64.debug/mksnapshot" --log-snapshot-positions --logfile "/hack/v8/out/x64.debug/obj.target/v8_snapshot/geni/snapshot.log" --random-seed 314159265 "/hack/v8/out/x64.debug/obj.target/v8_snapshot/geni/snapshot.cc"

My LD_LIBRARY_PATH isn't set so we will end up with:

LD_LIBRARY_PATH=/hack/v8/out/x64.debug/lib.host:/hack/v8/out/x64.debug/lib.targe
t:

which is incorrect as it implicitly adds the current directory.  I believe this 
is a problem in gyp/pylib/gyp/generator/make.py.

This bug report was originally filed as 
http://code.google.com/p/v8/issues/detail?id=3733.

Original issue reported on code.google.com by wi...@igalia.com on 2 Dec 2014 at 11:09