Open GoogleCodeExporter opened 9 years ago
I'm already making a CL to fix this.
Original comment by kind...@yandex-team.ru
on 15 Apr 2015 at 11:56
But I can't make a review. It always says: Access to
https://codereview.chromium.org is denied (server returned HTTP 401)
this is my patch attached
Original comment by kind...@yandex-team.ru
on 15 Apr 2015 at 1:11
Attachments:
Fixed here : https://codereview.chromium.org/1088163002
Original comment by kind...@yandex-team.ru
on 21 Aug 2015 at 3:25
https://codereview.chromium.org/1088163002 caused a serious regression in the
Chromium project: https://code.google.com/p/chromium/issues/detail?id=527935 .
Original comment by kbr@chromium.org
on 3 Sep 2015 at 7:54
Oh. That's bad.
I checked tests on Linux only.
I also tried "git try" but it didn't work.
I wrote about it, see
https://groups.google.com/forum/#!searchin/gyp-developer/kindrik/gyp-developer/Z
7j-ZMrpWR0/TvbwtrS5qs0J
And Dirk said
"More importantly, though, I don't expect the tryservers for gyp to work at
all. I'm in the process of moving the GYP bots off of the NaCl waterfalls and
onto their own. I hadn't really planned to set up tryservers for the new ones,
as the volume of changes GYP gets doesn't really merit them, but I can change
that if there's strong interest or demand for them.
In the absence of tryservers, I would probably just recommend test locally, get
your patch reviewed, land the changes, and see what happens on the waterfall
bots. It's not hard to revert things."
so I skipped "git try" and commited. But then I didn't check "what happens on
the waterfall bots" (I even don't know what is it and how to do that). Sorry!
Original comment by kind...@yandex-team.ru
on 4 Sep 2015 at 10:54
Original issue reported on code.google.com by
kind...@yandex-team.ru
on 15 Apr 2015 at 11:54