yuhangwang / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

gyp analyzer doesn't match targets which define inputs with '.' relative path values. #487

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

In chromium code:
1. Create a gyp target which includes "build/java.gypi" (let call it 'Test1'), 
add 'Test1' to 'all' target.
2. Define 'java_in_dir' variable with a value like './'
3. Prepare in.json for analyzer with any java file which would be dependent to 
Test1, something like 'path_to_our_gyp/src/org/some_path/some_file.java' in 
'files' and 'Test1' in 'targets' (Don't forget to create this file).
3. Run build/gyp_chromium --analyzer in.json out.json

More simple scenario: just create a gyp target with an action that has 
'./some_file' in its 'inputs'

What is the expected output? 

analyzer must print something like:

Found dependency
Supplied targets that depend on changed files:
    Test1
Targets that require a build:
    Test1

What do you see instead?

It will print instead:

No dependencies
Supplied targets that depend on changed files:
Targets that require a build:

Original issue reported on code.google.com by kind...@yandex-team.ru on 15 Apr 2015 at 11:54

GoogleCodeExporter commented 9 years ago
I'm already making a CL to fix this.

Original comment by kind...@yandex-team.ru on 15 Apr 2015 at 11:56

GoogleCodeExporter commented 9 years ago
But I can't make a review. It always says: Access to 
https://codereview.chromium.org is denied (server returned HTTP 401)

this is my patch attached

Original comment by kind...@yandex-team.ru on 15 Apr 2015 at 1:11

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed here : https://codereview.chromium.org/1088163002

Original comment by kind...@yandex-team.ru on 21 Aug 2015 at 3:25

GoogleCodeExporter commented 9 years ago
https://codereview.chromium.org/1088163002 caused a serious regression in the 
Chromium project: https://code.google.com/p/chromium/issues/detail?id=527935 .

Original comment by kbr@chromium.org on 3 Sep 2015 at 7:54

GoogleCodeExporter commented 9 years ago
Oh. That's bad.
I checked tests on Linux only.
I also tried "git try" but it didn't work.
I wrote about it, see 
https://groups.google.com/forum/#!searchin/gyp-developer/kindrik/gyp-developer/Z
7j-ZMrpWR0/TvbwtrS5qs0J

And Dirk said 

"More importantly, though, I don't expect the tryservers for gyp to work at 
all. I'm in the process of moving the GYP bots off of the NaCl waterfalls and 
onto their own. I hadn't really planned to set up tryservers for the new ones, 
as the volume of changes GYP gets doesn't really merit them, but I can change 
that if there's strong interest or demand for them.

In the absence of tryservers, I would probably just recommend test locally, get 
your patch reviewed, land the changes, and see what happens on the waterfall 
bots. It's not hard to revert things."

so I skipped "git try" and commited. But then I didn't check "what happens on 
the waterfall bots" (I even don't know what is it and how to do that). Sorry!

Original comment by kind...@yandex-team.ru on 4 Sep 2015 at 10:54