Closed dmi3y closed 11 years ago
Whops, travis failed with weird error.
Unit tests would go a long way toward convincing me this was good to pull. Ideally the coverage percentages would not drift significantly.
Also, you shouldn't be developing in your fork's master branch, it makes it much harder to keep up to date if the upstream moves under you. Pull requests work just as well from fork/working-branch
as they do from fork/master
.
Working on unit testings, also have to do take in count the branch convenience. So, possibly it would make sense close this pull request and open new in working-branch
?
Yes, that would be simplest. In your local clone, you can branch easily by doing the following:
git checkout -b lang-support-pres master
git push -u origin lang-support-pres
You can then open a new pull request originating from your working branch. Pushing new commits will trigger yui3's Travis build, so you can verify that your local tests are valid in all target environments.
Once you've done that, restoring your clone's master
to match upstream is a little more complicated:
git remote add upstream git@github.com:yui/shifter.git
git fetch upstream
git branch -D master
git checkout -b master upstream/master
git push -f -u origin master
The advantage of doing that is ease of syncing your working branches with the upstream master:
git checkout lang-support-pres
git pull upstream master
git push
Thanks Daniel for your help! Moving forward with modifications.
Basic support for YRB as it advertised in module intl re #94. Need to add some various tests and get cover them.