Package library with jarjar to prevent conflict of custom rhino impl

yui / yuicompressor

YUI Compressor

http://yui.github.com/yuicompressor/

Other

3.01k stars 663 forks source link

Package library with jarjar to prevent conflict of custom rhino impl #289

Open OlivierJaquemet opened 7 years ago

OlivierJaquemet commented 7 years ago

Update Java requirement : now build with and for 1.6
Include jarjar library (in its version 1.4.1 for compat with Java 8)
Change build process to create the jar with a completely rewritten package of Rhino. This will ensure that YuiCompressor can be bundle with any more up to date version of Rhino without ever conflicting

This PR should fix the following issues :

287
215 which is probably due to simultanueous use of other version of Rhino
161
38

OlivierJaquemet commented 7 years ago

Could it be that this build fails because of a change on Travis CI (and not due to the PR content itself) ?? https://blog.travis-ci.com/2017-08-31-trusty-as-default-status

melloware commented 7 years ago

Nice work. I really wish someone would just fork this project and take it over. This project seems dead and they are not really fixing PR's or doing any new releases.

OlivierJaquemet commented 7 years ago

Thanks @melloware. Yes quite unfortunate that this project no longer has any maintainer :(

benmccann commented 6 years ago

This change was also proposed in https://github.com/yui/yuicompressor/pull/179

OlivierJaquemet commented 6 years ago

@benmccann thanks for your feedbacks. PR updated.

The build is still not passing, but I don't get why it would be related to my commit. I suspect it is related to the recent change on Travis CI. But I am really not familiar with TravisCI and its build process... If you have any idea on this matter. It would be helpful.

yui / yuicompressor

Package library with jarjar to prevent conflict of custom rhino impl #289

287

215 which is probably due to simultanueous use of other version of Rhino

161

38