yuin / goldmark

:trophy: A markdown parser written in Go. Easy to extend, standard(CommonMark) compliant, well structured.
MIT License
3.68k stars 255 forks source link

Typographer does not replace apostrophes next to letters with accents (such as è) #121

Closed loup-brun closed 4 years ago

loup-brun commented 4 years ago

Please answer the following before submitting your issue:

  1. What version of goldmark are you using? : Hugo v0.68.3/extended (sorry, I don't know)
  2. What version of Go are you using? : Hugo v0.68.3/extended (sorry, I don't know)
  3. What operating system and processor architecture are you using? : Hugo Static Site Generator v0.68.3/extended darwin/amd64 BuildDate: unknown
  4. What did you do? : use typographer extension to replace ' =>
  5. What did you expect to see? : replacement of the apostrophe
  6. What did you see instead? : apostrophe next to character with accent is not replaced, such as é
  7. Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?: yes, output is different from the Commonmark online sandbox.
  8. (Feature request only): Why you can not implement it as an extension?:
    • You should avoid saying like "I'm not familiar with this project" "I'm not a Go programmer" as far as possible. This is an open source project and a library for Go programmers. I encourage you to strive to read source codes.
    • I absolutely welcome questions that are difficult even if you read the source codes.

Example

Apostrophe next to normal character with no accent gets replaced: Apostrophe next to accent-less gets replaced

Apostrophe next to e character with accent é does not get replaced: Apostrophe next to accent character é does not get replaced

I created the issue on the Hugo repo, but since it appears to work in the Commonmark online demo, I'm assuming the bug is currently in Goldmark.

Thanks!

loup-brun commented 4 years ago

Thanks!