[x ] goldmark is fully compliant with the CommonMark. Before submitting issue, you must read CommonMark spec and confirm your output is different from CommonMark online demo.
[ x] Extensions(Autolink without <>, Table, etc) are not part of CommonMark spec. You should confirm your output is different from other official renderers correspond with an extension.
[x ] goldmark is not dedicated for Hugo. If you are Hugo user and your issue was raised by your experience in Hugo, you should consider create issue at Hugo repository at first .
[ x] Before you make a feature request, you should consider implement the new feature as an extension by yourself . To keep goldmark itself simple, most new features should be implemented as an extension.
Please answer the following before submitting your issue:
What version of goldmark are you using? : v1.1.28
What version of Go are you using? : go 1.13.5
What operating system and processor architecture are you using? : darwin/amd64
I've encountered a bug in the implementation of Goldmark when a very specific pattern is used. In order to trigger the bug you:
Must have smart quotes enabled
Open a single quote
Have two numbers after the single quote
Have the letter "s" after the numbers
Have no further text before a line break
For example: This will trigger the bug: '00s
This pattern is commonly used to abbreviate a decade of years, e.g. "Happened in the '00s".
I've tried variations on that pattern but, while there may be things I've missed, it seems to only trigger in very specific cases. For now, disabling smart quotes in Hugo has fixed the issue.
<
>
, Table, etc) are not part of CommonMark spec. You should confirm your output is different from other official renderers correspond with an extension.Please answer the following before submitting your issue:
Ref https://github.com/gohugoio/hugo/issues/7172
I've encountered a bug in the implementation of Goldmark when a very specific pattern is used. In order to trigger the bug you:
For example:
This will trigger the bug: '00s
This pattern is commonly used to abbreviate a decade of years, e.g. "Happened in the '00s".
I've tried variations on that pattern but, while there may be things I've missed, it seems to only trigger in very specific cases. For now, disabling smart quotes in Hugo has fixed the issue.
Here is a simple example that reproduces the bug:
goldmark_73a80b32c2e375f8aff4b771c3a6b9de.txt
I expected to see the output rendered with a smart single quote, followed by the digits and the "s".
I'm using Hugo, and it crashed with a
goldmark: runtime error: index out of range [4] with length 4
error. The full stack trace can be found below:Yes, the online demo worked fine.