search

yuin / goldmark

:trophy: A markdown parser written in Go. Easy to extend, standard(CommonMark) compliant, well structured.
MIT License
3.68k stars 255 forks source link

Setting the type attribute in the attribute list for an ordered list does not show up in the final markup #206

Closed faraixyz closed 3 years ago

faraixyz commented 3 years ago

Please answer the following before submitting your issue:

  1. What version of goldmark are you using? : v1.3.2
  2. What version of Go are you using? : 1.16
  3. What operating system and processor architecture are you using? : Windows
  4. What did you do? : I tried to use the type attribute in the attribute list of an ordered list.
  5. What did you expect to see? : The type attributes in the ol element
  6. What did you see instead? : The type attribute wasn't there
  7. Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?: N/A

I initially reported it for Hugo. I have a demo and some code.

jmooring commented 3 years ago

https://github.com/yuin/goldmark/blob/master/renderer/html/html.go#L317-L320

Do we just need to add 'type' to this list? It's a valid attribute.

faraixyz commented 3 years ago

Pretty much