Closed lschierer closed 2 years ago
As mentioned in README, goldmark's footnote is an implementation of Markdown Extra.
Please try dingus https://michelf.ca/projects/php-markdown/dingus/
php markdown extra via dingus tested with the following input:
test text[^some] more text
[^some]: test
* one
* two
* three
produced the following html, which looks correct:
<p>test text<sup id="fnref:some"><a href="#fn:some" class="footnote-ref" role="doc-noteref">1</a></sup> more text</p>
<div class="footnotes" role="doc-endnotes">
<hr />
<ol>
<li id="fn:some" role="doc-endnote">
<p>test
* one
* two
* three <a href="#fnref:some" class="footnote-backref" role="doc-backlink">↩︎</a></p>
</li>
</ol>
</div>
note there is only one level of list in the above output.
mm. interesting, though that it treated the entire thing as a single list item. which isn't correct, but a different error than goldmark is generating.
the test text
test text[^some] more text
[^some]:
* one
* two
* three
produces nearly the same error as goldmark:
<p>test text<sup id="fnref:some"><a href="#fn:some" class="footnote-ref" role="doc-noteref">1</a></sup> more text</p>
<div class="footnotes" role="doc-endnotes">
<hr />
<ol>
<li id="fn:some" role="doc-endnote">
<ul>
<li>one</li>
<li>two</li>
<li>three</li>
</ul>
<p><a href="#fnref:some" class="footnote-backref" role="doc-backlink">↩︎</a></p>
</li>
</ol>
</div>
the difference being that goldmark (correctly) does not actually show an ordered list with a numbered bullet point in the extra wrapping list.
I see what's happening, it is implementing the footnotes themselves as an ordered list, so the bullets inside are a second order list. Okay, that makes sense. Closing this.
goldmark has https://github.com/yuin/goldmark/discussions in github. You should post only issues here. Feature requests and questions should be posted at discussions.
<
>
, Table, etc) are not part of CommonMark spec. You should confirm your output is different from other official renderers correspond with an extension.Please answer the following before submitting your issue:
As footnotes are an extension, I did not check with CommonMark. I not aware of a good way to test this in another renderer with this extension, but happy to do so.