yuj / sublime-parquet

A Sublime Text package for viewing Apache Parquet files
https://yuj.github.io/sublime-parquet/
MIT License
26 stars 5 forks source link

Proposal to use python libs instead of parquet tools #5

Open pokidovea opened 5 years ago

pokidovea commented 5 years ago

It is not convenient to install Java-based parquet tools. There is at least one python lib for work with parquet pyarrow. There are some advantages to use this lib:

What do you think?

yuj commented 2 years ago

I agree that it's a good idea to use a python lib to read in parquet files. Editing parquet files might be a bit inefficient using any text editor.

dogversioning commented 1 year ago

@yuj would you be interested in taking a PR to accomplish this? I tried to do this separately as a fork (https://github.com/dogversioning/sublime-parquet-python), which changes the rendering options (the python tools I used as a first pass don't support JSON output), but the sublime text folks have a light preference to consolidate these approaches if possible.

yuj commented 1 year ago

@dogversioning PRs are always welcome! Please send it over.

Eventually I guess we all still prefer @pokidovea suggestion that uses pyarrow to read parquet files, instead of using parquet-tools. Anyone interested in accomplish that too? :)

dogversioning commented 1 year ago

@yuj yeah, i think it makes sense - this was more of an incremental approach to solve an acute issue, but something like that was next on my list of things to potentially tackle.

Anyway, give me a bit to reconcile the fork approach with a in place one and i'll open a PR.

dogversioning commented 1 year ago

@yuj So I spent a little time this morning looking into this - there's some tradeoffs:

If the first one doesn't bother you and you're ok with the hoops on the latter (I think for something of this scope the pre-built route isn't worth the effort), than it :could: be done. But it's an open question if this makes the barrier to entry too complex.

[1] https://stackoverflow.com/questions/61196270/how-to-properly-use-3rd-party-dependencies-with-sublime-text-plugins