yujacorp / moodle-local_yujaverity

Verity Moodle Plugin
0 stars 0 forks source link

consider using the after_require_login callback instead of events for adding classes to Page #9

Open danmarsden opened 1 year ago

danmarsden commented 1 year ago

Events are usually triggered quite late in the page load, and sometimes will occur after page output has been generated.

you might find it cleaner/more efficient to use the after_require_login callback in your code instead...

defined a function called "local_yujaverity_after_require_login()" in your lib.php then drop the code you put into the event handler there: https://github.com/yujacorp/moodle-local_yujaverity/blob/main/classes/event/view_quiz.php#L38-L45

using this callback is probably a lot more efficient on server performance too. you can see more on callbacks here: https://docs.moodle.org/dev/Login_callbacks#after_require_login

and here: https://docs.moodle.org/dev/Callbacks