yujiahui / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

ninja generator is not aware of VCLinkerTool.GenerateManifest #389

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Generate ninja build file from following gyp file
2. ninja -C out/Default hello

What is the expected output? What do you see instead?
Actual: hello.exe.manifest is generated.
Expected: hello.exe does not have any manifest file.
msvs generator does not have this issue.

Please use labels and text to provide additional information.

{
  'targets': [
    {
      'target_name': 'hello',
      'type': 'executable',
      'sources': ['hello.cc'],
      'msvs_settings': {
        'VCLinkerTool': {
          'EnableUAC': 'true',
          'GenerateManifest': 'false',
        },
      },
    },
  ],
}

Original issue reported on code.google.com by yukawa@chromium.org on 2 Dec 2013 at 4:39

GoogleCodeExporter commented 9 years ago
Fixed in r1802.

Original comment by yukawa@chromium.org on 3 Dec 2013 at 2:47