yujiaxin666 / rockphypy

extensive Python library for rock physics modelling
https://rockphypy.readthedocs.io/en/latest/
GNU Lesser General Public License v3.0
34 stars 10 forks source link

HTI approximation and/or test has errors #2

Open gpap-gpap opened 4 weeks ago

gpap-gpap commented 4 weeks ago

The test case for azimuthal AVO should not pass. The matrix being tested is a VTI matrix over ISO and there should be no azimuthal dependence in this case which indicates either an error with the AVO_HTI method or the test case itself.

Additionally, there should be some justification for the result being tested (i.e. is this from a paper?).

yujiaxin666 commented 4 weeks ago

HI, I will check that and get back to you asap. Thanks.

gpap-gpap commented 3 weeks ago

Hi, following back to this, I think the issue would be solved if the AVO_HTI method checks for cij symmetry (and raises an exception when the input is neither of ISO or HTI). It would then fail the test but that should be expected behaviour in my opinion. I can pick it up after I get back from IMAGE this week unless you object to the above