search

yujinakayama / atom-lint

Obsolete: Generic code linting support for Atom
https://atom.io/packages/atom-lint
MIT License
111 stars 33 forks source link

Moving count outside of icon #29

Closed jonrohan closed 10 years ago

jonrohan commented 10 years ago

There's a small visual bug for the icon with the warnings. It is a little too close to the number

Before: screen shot 2014-03-22 at 3 35 32 pm

After: screen shot 2014-03-22 at 3 35 05 pm

@yujinakayama

yujinakayama commented 10 years ago

I agree it's a little too close. However your after looks a little too far to recognize the icon and label as a group. :) Especially when both error and warning counts are displayed:

screen shot 2014-03-23 at 16 39 46

I've tweaked the stylesheet instead of the DOM structure in my local environment:

screen shot 2014-03-23 at 16 41 24

Is this acceptable to you?

jonrohan commented 10 years ago

Yeah looks good.