yujinakayama / atom-lint

Obsolete: Generic code linting support for Atom
https://atom.io/packages/atom-lint
MIT License
111 stars 33 forks source link

Detect clang flags #70

Closed Kev closed 10 years ago

Kev commented 10 years ago

Hi, I have tested this locally, and it's working for me by picking up my .clang_complete for the project and using those compile flags to let the linter show meaningful hits. I think I've done the appropriate thing with code styles, but I am new to coffeescript, node and atom, so I welcome feedback.

yujinakayama commented 10 years ago

Seems good idea. However I cannot find the clang-flags npm package, am I missing something?

Kev commented 10 years ago

Ah - it's an Atom package (https://atom.io/packages/clang-flags); I guess I put the dependency in in the wrong way, sorry. I'll try to find out how to put a dependency on an Atom package instead, but if you know how already that could save me some time (I'm not finding documentation on Atom packages to be trivial to find at this stage).

Kev commented 10 years ago

I've corrected the reference, although as far as I can tell this had to be by pointing at the github repository directly.

Does this look like the correct fix? Beyond this, the only other option I can find is to convert it instead to an npm package and publish there.

Kev commented 10 years ago

No, that's still not right, because it looks like apm doesn't check out the dependencies of my package. I guess the only thing that's left is working out how to make it into an npm package instead. So don't merge this for the moment, please. I'll finish it off when I have a chance.

Kev commented 10 years ago

I finally gave up and made it into an npm package instead. So this PR should now be right. I've tested this branch locally by checking it out with apm develop, git checkout of the right branch, rm -rf node_modules, apm install, then firing up dev mode in Atom to check that it's doing linting using my clang flags. I don't know how to retrigger the Travis build, though.

yujinakayama commented 10 years ago

Yeah, I agree that making it an npm package is the right way.

Kev commented 10 years ago

Thanks, I've made both changes.

yujinakayama commented 10 years ago

Thank you!