Add atom-lint.rubocop.showDisplayCopNames #47

yujinakayama / atom-lint

Obsolete: Generic code linting support for Atom

https://atom.io/packages/atom-lint

MIT License

111 stars 33 forks source link

Add atom-lint.rubocop.showDisplayCopNames #47 #82

Closed rochefort closed 10 years ago

rochefort commented 10 years ago

I want to use rubocop with --display-cop-names option. How about this?

yujinakayama commented 10 years ago

Thanks for the pull request.

I like the idea, but I have two concernes:

We don't need to specify the --display-cop-names CLI option. atom-lint internally uses RuboCop's JSON formatter, and the outputted JSON always contains cop name information which is smarter than the one embedded in a message with --display-cop-names option.
Maybe we can improve the appearance of the cop name display in the tooltip. I'm thinking a good way to do this now.

rochefort commented 10 years ago

the outputted JSON always contains cop name

That's true. I am sorry that I overlooked that.

I'm thinking a good way to do this now.

great!! I'm expecting you a lot.

yujinakayama commented 10 years ago

I built a prototype of the cop name display style.

screen shot 2014-08-10 at 2 04 52

What do you think?

rochefort commented 10 years ago

I think it's good. :congratulations:

yujinakayama commented 10 years ago

I've just released atom-lint 0.16.0 with the support for cop names. Actually it's implemented as a concept “violation metadata” so we can add more information later (even in linters other than RuboCop) in the same way.

There are a new configuration option and a keymap to toggle the metadata display. See changelog for the details.

Finally, thanks for the suggestion!