search

yujing-student / lose-your-head-the-client-case

Ontwerp en maak een website voor een opdrachtgever op basis van een Headless CMS API
https://lose-your-head-the-client-case-dda.vercel.app
MIT License
0 stars 0 forks source link

Restructure your top level section elements #8

Open joostf opened 1 week ago

joostf commented 1 week ago

https://github.com/yujing-student/lose-your-head-the-client-case/blob/690e2cc7dab75b7af4788967e544703a71eec255/src/lib/Member.svelte#L6-L8

An article element in an article element, both without a heading, doesn't look as a fitting semantic structure.

yujing-student commented 1 day ago

@joostf

We are working in the repository of lisa and this repo I use te test my memebrs page in PageSpeed Insight. I have currently the problem that the results in PageSpeed Insight are better than i lighthouse.

And I use the livelink to test the memberspage in browserstack before the merge to the main.

See here the permalinks where i added a h2 for semantic.

https://github.com/lisagjh/voorhoede/blob/4c22446969e5c4f70f0f2efaf3f7e2aad8bd9ada/src/lib/Member.svelte#L10

https://github.com/lisagjh/voorhoede/blob/4c22446969e5c4f70f0f2efaf3f7e2aad8bd9ada/src/lib/Member.svelte#L27

When i was making this component it was quite difficult because the elements in the cards must have the same height.

image