Closed v4hn closed 8 years ago
@stonier: you are the only one who touched this repository over the last year. Do you have a moment to review this request as well as #363 ? Both improve the overall quality and don't add new features.
This request has to break the API to achieve remappability of the node. This is important for multi-master setups with multiple kobuki/turtlebot bases.
I would prefer to see them released in indigo, but if they would be available in kinetic this is good enough I suppose.
@v4hn thanks for your contribution. We will get around reviewing it eventually.
There has been some updating and release work for TurtleBot, which we focused on, and now we are currently busy with a field test. Once the team is back and the dust settles we will test this out (probably need to test it together with the full turtlebot stack to ensure it's not breaking compatibility somewhere.).
ping
Thanks for the fix.
_ _(o)_(o)_ _
._\`:_ F S M _:' \_,
/ (`---'\ `-.
,-` _) (_,
Cherried to kinetic in e9063722
Thank you for merging!
There is no reason to address "/robot_description" instead of "robot_description" with a non-private node-handle. It breaks namespacing to use '/' in the beginning, and we had trouble moving the whole turtlebot_bringup/minimal.launch into a namespace because of that.