search

yujinrobot / kobuki_desktop

Visualisation and simulation tools for Kobuki
http://www.ros.org/wiki/kobuki_desktop
37 stars 58 forks source link

Kobuki Gazebo Updates. #34

Closed jihoonl closed 10 years ago

jihoonl commented 10 years ago

It utilise GazeboRos Utilities for tf prefix and topic namespacing.

Referenced GazeboRosDiffDrive.

Also now it has base_prefix parameter to configure mobile base namespace. So now we can use topics in following way.

odom tf joint_state

/commands/velocity /sensors/xxx /events/xxx
jihoonl commented 10 years ago

@bit-pirate Can you review this PR?

bit-pirate commented 10 years ago

I can and will, but after IFA.

jihoonl commented 10 years ago

@bit-pirate bump

jihoonl commented 10 years ago

I have applied your suggestions. And created a new issue to follow-up licensing. Please don't mix up the PR with different issue.

bit-pirate commented 10 years ago

PR looks fine. However, I'm unable to test it. When I checkout this branch I get this warning and error:

Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Warning [gazebo.cc:215] Waited 1seconds for namespaces.
Error [gazebo.cc:220] Waited 11 seconds for namespaces. Giving up.
Error [Node.cc:90] No namespace found

Do I need any other updates to make this work?

PS: I using roslaunch kobuki_gazebo kobuki_empty_world.launch for testing.

jihoonl commented 10 years ago

empty_world and play_ground with randomwalker app work fine in my pc.

Does it happen every time? with clean compilation?

bit-pirate commented 10 years ago

I have updated my workspace sources (using indigo branches) and my ROS debs are also up to date.

Do you have any commits/PRs pending for other repos?

This error says it's missing a parameter for the namespace. Where does this need to be defined?

On 18 September 2014 09:49, Jihoon Lee notifications@github.com wrote:

empty_world and play_ground with randomwalker app work fine in my pc.

Does it happen every time? with clean compilation?

— Reply to this email directly or view it on GitHub https://github.com/yujinrobot/kobuki_desktop/pull/34#issuecomment-55982081 .

Innovation Team Leader Yujin Robot Seoul, Republic of Korea Twitter: @yujinrobotinno Website: http://inno.yujinrobot.com Email: marcus.liebhardt@yujinrobot.com Phone: +82-70-46577073

bit-pirate commented 10 years ago

So, the issue was the slow loading online gazebo models. Now it's working fine. PR tested and verified.