search

yujinrobot / kobuki_desktop

Visualisation and simulation tools for Kobuki
http://www.ros.org/wiki/kobuki_desktop
37 stars 58 forks source link

fix the wrong behavior with a kobuki model on Gazebo5. #42

Closed DaikiMaekawa closed 8 years ago

DaikiMaekawa commented 8 years ago

https://github.com/yujinrobot/kobuki_desktop/issues/41 I modified to not use SetMaxForce method.

Review on Reviewable

DaikiMaekawa commented 8 years ago

The plugin isn't working on Gazebo5 before, so that this PR is necessary aid for avoiding the wrong behavior with ROS Jade. Can you review this one, and then merge it?

DaikiMaekawa commented 8 years ago

@bit-pirate Poke

bit-pirate commented 8 years ago

First, thanks for the contribution @DaikiMaekawa !

For Kobuki (and TurtleBot) we only support long-term releases, so no Jade. However, I don't want your contribution to be wasted, so I have created a jade branch. Please rebase this PR against the jade branch.

DaikiMaekawa commented 8 years ago

@bit-pirate done. https://github.com/yujinrobot/kobuki_desktop/pull/43