Closed rohbotics closed 8 years ago
@rohbotics could you squash these commits into one?
@stonier Squashed
@stonier After merging can you run a kinetic release, so that we can release turtlebot_interactions?
@rohbotics I'm trying this out and the change to CMakeLists.txt breaks if CMAKE_CXX_FLAGS
is set. Can you make a minor change as in https://github.com/turtlebot/turtlebot_create_desktop/commit/9aec5e09cc32e236800502c3825480b7db6af382 ? It may also be better to use the CXX_STANDARD
property instead.
@leokoppel, Fixed. Please try it out now
@rohbotics Yep it builds.
I'm currently getting a segfault when the .so is loaded, but I'm pretty sure it's just my system (from Kinetic migration guide: "Code that links against both Qt4 and Qt5, directly or indirectly, will segfault. ") Still figuring it out (i.e. rebuilding everything) but thought I'd mention it in case anyone had the same issue.
@stonier re-squashed
Thanks!
_ _(o)_(o)_ _
._\`:_ F S M _:' \_,
/ (`---'\ `-.
,-` _) (_,
Any further problems you have, keep sending the PR's. We are not actively using kinetic yet, so relying a bit on users for a while.
Working on getting a deb release out now.
Awesome, Thanks!
Rebase of #45