search

yujinrobot / yujin_ocs

Yujin Robot's open-source control libraries
http://wiki.ros.org/yujin_ocs
242 stars 181 forks source link

remove ecl dependency, use boost. #102

Closed asimay closed 8 years ago

asimay commented 8 years ago

use boost thread, remove ecl thread dependency.

stonier commented 8 years ago

Is this actually solving a problem? If not, I'd prefer to leave as is (always better not to mess with working code unless there is a good reason).

  1. If there is going to be a thread upgrade, I would prefer to wait until c++11 is the default in gcc, no point upgrading now to something which will deprecate anyway
  2. The plugin macro check is redundant, this is a kinetic branch (refer to the wiki.
asimay commented 8 years ago

hi, dear @stonier , just for use convenience, because ecl need to update the ecl library, boost is commonly used and doesn't need to download separately. It's fine if the code change not suitable. Thanks!

stonier commented 8 years ago

ECL is our 'boost' like set of libraries for re-usable non-ros code across platforms and gets used here and there in the yocs for things other than threads as well. It's very light and stable - we use it in several hundred thousand cleaning robots running arm cores as low as armv6 (where boost can't go). Even if we removed the threads, it would still be getting pulled in elsewhere.

I like to minimise dependencies, but I also like to re-use and write simple code. This is one of those cases where you can't have both. Anyways, making the upgrade to c++11 will take the maintenance burden out of alot of ecl/boost code, so looking forward to being able to upgrade to that at the right time.