Dynamic joy - Githubissues

yujinrobot / yujin_ocs

Yujin Robot's open-source control libraries

http://wiki.ros.org/yujin_ocs

235 stars 178 forks source link

Dynamic joy #115

Closed haryngod closed 7 years ago

haryngod commented 7 years ago

dynamic reconfigure client for joystick.
add launch for unit testing.
connection loop for client

stonier commented 7 years ago

BagJoystick -> ReconfigureJoystick
reconfigure_joystick.launch -> demo_reconfigure_joystick.launch
rospy.spin() instead of a kinda doing nothing custom spin.

stonier commented 7 years ago

@haryngod why is magic_button_relay.py → joystick_map_bagging_button.py?

haryngod commented 7 years ago

@stonier Didn't you let me change that?

Ah, I thought you want to edit all the name should be renamed. Then I didn't back to origin...

stonier commented 7 years ago

@haryngod Thinking hats required!

Across so many packages, scope is an important concept. Someone else looking at this repo has absolutely no idea about joystick_map_bagging and does not need to. This kind of thing will just make it confusing for users and future developers of this package.