search

yujinyuz / gitpad.nvim

minimal neovim plugin for taking down notes for git projects, branch, etc.
https://yujinyuz.github.io/gitpad.nvim/
MIT License
43 stars 4 forks source link

Fix `E79` error on fish shell #2

Closed krehwell closed 1 month ago

krehwell commented 1 month ago

issue

on fish shell, calling toggle_gitpad prompt an error E79: Cannot expand wildcards

causes

it's because fish does not support basename. So, calling this line does not work

local repository_name = vim.fn.systemlist('basename `git rev-parse --show-toplevel`')[1] --> `git

solution

call basename from bash considering all terminal should support bash anyway

yujinyuz commented 1 month ago

Thanks @krehwell

I'm using fish as well and didn't have this problem. I guess it's because I'm using /bin/bash in my vim.o/shell

krehwell commented 1 month ago

glad I can be useful 😁. great plugin!!