search

yujinyuz / gitpad.nvim

minimal neovim plugin for taking down notes for git projects, branch, etc.
https://yujinyuz.github.io/gitpad.nvim/
MIT License
43 stars 4 forks source link

feat(title): add title configuration for window #4

Closed sudo-tee closed 1 month ago

sudo-tee commented 1 month ago

The title can now be configured in the setup or when toggling the window.

sudo-tee commented 1 month ago

Thanks for your great plugin.

I tought it would be nice to customize the title of the window either with the setup or when togling the window.

yujinyuz commented 1 month ago

@sudo-tee This looks awesome!

I just tried your branch with my current config and I'm getting this problem.

I think it's because you removed the opts = opts or {} declaration

E5108: Error executing lua: vim/shared.lua:0: after the second argument: expected table, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'tbl_deep_extend'
        ...rces/github.com/yujinyuz/gitpad.nvim/lua/gitpad/init.lua:194: in function 'toggle_gitpad'
        /Users/traf/.config/nvim/lua/my/plugins.lua:829: in function </Users/traf/.config/nvim/lua/my/plugins.lua:828>

Other than that, everything looks good to me!

sudo-tee commented 1 month ago

Thanks for looking at it,

It shoud be fixed now.

yujinyuz commented 1 month ago

@sudo-tee

Merged. Thanks for your contribution!