yujitach / MenuMeters

my fork of MenuMeters by http://www.ragingmenace.com/software/menumeters/
GNU General Public License v2.0
3.02k stars 223 forks source link

General issues on Catalina #113

Closed objjg closed 5 years ago

objjg commented 5 years ago

I have tried to install 1.9.8 but it just fails and locks up my MacBook Pro with a beachball I can't stop, while 1.9.6 works perfectly on my machine. It installs and runs fine..

emcrisostomo commented 5 years ago

I wasn't able to replicate this problem on my branch, where a pkg installer is provided. You may try it and give your feedback:

https://github.com/emcrisostomo/MenuMeters/releases

objjg commented 5 years ago

Yup.. 1.9.8.1 works great so far.. thank you so much.

Mike

M.G. Ferris 356 Waddell Road, Erinsville, Ontario K0K 2A0

On Oct 19, 2019, at 12:57 PM, Enrico Maria Crisostomo notifications@github.com wrote:

I wasn't able to replicate this problem on my branch, where a pkg installer is provided. You may try it and give your feedback:

https://github.com/emcrisostomo/MenuMeters/releases https://github.com/emcrisostomo/MenuMeters/releases — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yujitach/MenuMeters/issues/113?email_source=notifications&email_token=AJCQRBCPVPYLLEXZOMAQPHLQPM37DA5CNFSM4JCM4XUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXWR6I#issuecomment-544172281, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCQRBEXUYUQOGSF3YQG3ALQPM37DANCNFSM4JCM4XUA.

luckman212 commented 5 years ago

1.9.8.1+emc working well for me too, on 2 computers, both 10.15

sysfu commented 5 years ago

1.9.8.1+emc dmg installer did the trick here as well. Interestingly it told me it was replacing an 'older version' of menumeters.

emcrisostomo commented 5 years ago

I'm glad it works!

yujitach commented 5 years ago

Thanks @emcrisostomo , I recommended your version from my release page https://github.com/yujitach/MenuMeters/releases/tag/1.9.8 .

I didn't understand why you liked pkg installers, but finally I saw your point :-p I might incorporate your pkg installer to my side. How are you notarizing it?

I was also thinking of moving out of System Preferences to make MenuMeters a stand-alone app, because debugging with System Preferences is very hard with System Integrity Protection...

emcrisostomo commented 5 years ago

You're welcome @yujitach. :)

I'm not notarising, but we could if we wanted to. When I created the pkg, the idea was just streamlining installation and update for users who build the software.

I completely agree on your second point: having those two targets is a pain, and it complicates the project configuration quite a bit. We can get our hands on it. I'll try to allocate some time to refactor the project and contribute to it.

yujitach commented 5 years ago

Wait, can a non-notarized app run in Catalina on a non-development machine? I thought otherwise, from the documentations. My 1.9.8 is notarized.

emcrisostomo commented 5 years ago

Hi @yujitach, yes, it can, at the moment at least. I've read somewhere that notarization requirements are still 'relaxed', but I'll have to check the documentation. We can automate the notarization step when building the installer, anyway.

Tobbak commented 5 years ago

On 1.9.8 and connected over Gigabit Ethernet MenuMeters only shows the Tx and not the Rx Rate. Its just all the time on zero. Connected only to the wifi it works. Bildschirmfoto 2019-10-23 um 08 23 48

cattyhouse commented 5 years ago

@emcrisostomo thanks for your mod, it does not freeze Settings anymore on 10.15, but i can't get dark theme in menumeters settings, while my system is on Dark, here are some logs:

default 02:03:46.768712+0800    legacyLoader    setLegacyPreferencePanePath: /Library/PreferencePanes/MenuMeters.prefPane
default 02:03:46.837919+0800    runningboardd   Acquiring assertion targeting executable<MenuMetersApp(501)> from originator [daemon<com.apple.coreservices.launchservicesd>:155] with description <RBSAssertionDescriptor; frontmost:1923; ID: 306-155-328; target: 1923> attributes = {
    <RBSDomainAttribute: 0x7fbf4b519330; domain: com.apple.launchservicesd; name: RoleUserInteractiveFocal; sourceEnvironment: 0x0>;
}
default 02:03:46.838085+0800    runningboardd   Assertion 306-155-328 (target:executable<MenuMetersApp(501)>) will be created as active
default 02:03:46.839822+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Ignoring jetsam update because this process is not memory-managed
default 02:03:46.841708+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Set darwin role to: UserInteractiveFocal
default 02:03:46.842247+0800    runningboardd   Finished acquiring assertion 306-155-328 (target:executable<MenuMetersApp(501)>)
default 02:03:46.842344+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Ignoring GPU update because this process is not GPU managed
error   02:03:46.868649+0800    kernel  Library Validation failed: Rejecting '/Library/PreferencePanes/MenuMeters.prefPane/Contents/MacOS/MenuMeters' (Team ID: none, platform: no) for process 'System Preferenc(1947)' (Team ID: none, platform: yes), reason: mapped file has no cdhash, completely unsigned? Code has to be at least ad-hoc signed.
default 02:03:46.868702+0800    System Preferences  Error loading /Library/PreferencePanes/MenuMeters.prefPane/Contents/MacOS/MenuMeters:  dlopen(/Library/PreferencePanes/MenuMeters.prefPane/Contents/MacOS/MenuMeters, 0x0109): code signature in (/Library/PreferencePanes/MenuMeters.prefPane/Contents/MacOS/MenuMeters) not valid for use in process: mapped file has no cdhash, completely unsigned? Code has to be at least ad-hoc signed.
default 02:03:46.944746+0800    distnoted   register name: com.ragingmenace.MenuMeters object: prefChange token: f430b pid: 1965
default 02:03:49.889101+0800    runningboardd   Invalidating assertion 306-155-328 (target:executable<MenuMetersApp(501)>) from originator 155
default 02:03:49.991548+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Ignoring jetsam update because this process is not memory-managed
default 02:03:49.991656+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Set darwin role to: UserInteractive
default 02:03:49.992039+0800    runningboardd   [executable<MenuMetersApp(501)>:1923] Ignoring GPU update because this process is not GPU managed
cattyhouse commented 5 years ago

and more

error   02:24:05.088196+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
fault   02:24:05.088268+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
error   02:24:05.088335+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
fault   02:24:05.088393+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
error   02:24:05.092372+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
fault   02:24:05.092443+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
error   02:24:05.092495+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
fault   02:24:05.092550+0800    System Preferences  CoreUI: RunTimeThemeRefForBundleIdentifierAndName() couldn't find Assets.car in bundle with identifier: 'com.yujitach.MenuMeters'
yujitach commented 5 years ago

@cattyhouse This is a general bug of Catalina's System Preferences, where non-system pref panes do not respect the dark mode at all. See https://www.noodlesoft.com/blog/2019/08/28/preference-panes-and-catalina/

cattyhouse commented 5 years ago

@yujitach Thanks for the info. i've also install latest version of your build on my old MacBook Air 2013, 10.15 (19A602), MenuMeters pane respects dark mode actually and no freezing System Preferences, it works perfect.

But on my hackintosh iMac (Retina 4K, 21.5-inch, 2019) with 10.15 (19A602), your version freeze System Preferences, after CMD+OPT+ESC force quit System Preferences, it does not freeze anymore, but no dark mode, then I removed everything (sudo find /Library/ -iname "*menumeters*" -exec rm -rf {} \; ) and installed MenuMeters v. 1.9.8.1+emc, it does not freeze, but still no dark mode.

yujitach commented 5 years ago

Dear everyone, could you try my preliminary version https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/MenuMeters_1.9.9.zip which runs outside of System Preferences?

There will be still many bugs, but this is the way forward, and I need volunteers who sacrifice themselves :-p

sysfu commented 5 years ago

Downloaded and launched. Sparkle updater tried download version 2.0.0 but failed. Was unable to reproduce Sparkle update check for screenshot. Seems to be working properly otherwise.

cattyhouse commented 5 years ago

wow, this one (app) works flawlessly on my hackintosh macOS 10.15 and it is natively Dark Mode, settings can be called by clicking anywhere on the menubar, this is very nice.

while there are 2 small issues:

  1. on openning the app, it says there is a version 2.00, but failed to download. there is no place to call the "update" afterward, btw, i already dragged it to /Applications
  2. the only way to quit is by Activity Monitor or by kill from Terminal?
yujitach commented 5 years ago

Hi, could you try a new version (with the same version) again? https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/MenuMeters_1.9.9.zip

It should now have a Dock menu, if you bring up the preferences. From there, you can force update and/or quit the app. At least I can successfully update it to 2.0.0.

The difference between 1.9.9 and 2.0.0 is solely in the version number, and they are there to test if the auto-updater works correctly. Thanks again for being guinea pigs.

I'd like to make MenuMeters' main menu to appear in the menu bar wen the preference window is open. So far I can only make it happen inconsistently.

cattyhouse commented 5 years ago

I can see there is MenuMeters in Dock when opening preferences from menubar,

cattyhouse commented 5 years ago

Wait a moment, what is the server address that hosts the updates? i checked my local DNS server logs, i don't see any DNS query when Check for Updates and Install Update, is it ipv6 only?

yujitach commented 5 years ago

It's on https://member.ipmu.jp/ . The update manifest is at https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/MenuMeters-Update.xml

It's very strange that you can't update... I can update from my machine. If I can't reproduce the problem there's no way for me to fix it ...

cattyhouse commented 5 years ago

it is really strange, i can download https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/logger.php?MenuMeters_2.0.0.zip via safari or chrome without problem.

open https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/MenuMeters-Update.xml in Safari redirect me to feed:https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/MenuMeters-Update.xml, which results Safari can't open because no RSS reader is installed

open https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/MenuMeters-Update.xml in chrome shows the source of xml, that is where i get the directly download URL of version 2.0.0

looking forward to more testers on this issue.

cattyhouse commented 5 years ago

more logs from Console.app, looks like the url embedded in MenuMeters app was not https:

Error: An error occurred while downloading the update. Please try again later. (null) (URL http://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/MenuMeters_2.0.0.zip)

Error: The resource could not be loaded because the App Transport Security policy requires the use of a secure connection. (null) (URL http://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/MenuMeters_2.0.0.zip)
yujitach commented 5 years ago

Hi, I corrected the server setting. Could you try updating again?

cattyhouse commented 5 years ago

Hi, I corrected the server setting. Could you try updating again?

Great, update works now, thank you very much.

yujitach commented 5 years ago

Glad to know it worked. Thank you for your help, @cattyhouse .

yujitach commented 5 years ago

Again I'd like volunteers to test the new version, running outside of System Preferences: https://member.ipmu.jp/yuji.tachikawa/MenuMetersElCapitan/zips/MenuMeters_1.9.9.zip

piadam commented 5 years ago

Everything went just fine on my Mojave 10.14.6 (18G1011) MacBook Pro. Version 2.0.0 looks good to me!

Kind regards, Adam

mdogan commented 5 years ago

New app works fine on Catalina 10.15 (19A602). I haven't seen any issues and upgraded to 2.0.0.

Thanks for your great work.

luckman212 commented 5 years ago

Another positive report - Catalina 10.15.1 - 1.9.9 + update to 2.0.0 worked fine! 💯

ReubenBTalbott commented 5 years ago

I also was able to update from 1.9.9 to 2.0 once I installed 1.9.9

On Wed, Oct 30, 2019 at 4:01 PM Luke Hamburg notifications@github.com wrote:

Another positive report - Catalina 10.15.1 - 1.9.9 + update to 2.0.0 worked fine! 💯

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yujitach/MenuMeters/issues/113?email_source=notifications&email_token=AET2UNB5ZTSSAHCSACCH5ETQRHR23A5CNFSM4JCM4XUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECVSPYY#issuecomment-548087779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AET2UND3HWCV2TTVIFFPJYLQRHR23ANCNFSM4JCM4XUA .

-- Reuben Talbott (;-)

Sent from my iPhone 6S using Gmail for iOS

sysfu commented 5 years ago

I was able to install the latest test copy of MenuMeters 1.9.9, check for updates, and upgrade to 2.0.0 without error.

subotic commented 5 years ago

Install of 1.9.9 and update to 2.0.0 went fine.

veldechev commented 5 years ago

Works for me as well! 1.9.9 > 2.0.0

Awesome work! Thanks a lot!

For anybody wondering how to update or for TL;DR guys, just right-click on the dock icon after opening the preferences.

image
yujitach commented 5 years ago

I'd like to thank all the volunteers for testing it. I consider v1.9.9 good enough, so created the release https://github.com/yujitach/MenuMeters/releases/tag/1.9.9 . The binary is identical to the one posted in this thread, so you don't have to download it again if you already have installed it.