search

yujitach / MenuMeters

my fork of MenuMeters by http://www.ragingmenace.com/software/menumeters/
GNU General Public License v2.0
3.02k stars 223 forks source link

M1 pro/max fix #256

Closed agraf closed 3 years ago

agraf commented 3 years ago

When running MenuMeters on an M1 Max (I believe M1 Pro suffers from the same problem), it immediately crashes on start. The reason is simple: We're releasing a NULL pointer. This simple fix makes MenuMeters work on M1 Max for me.

yujitach commented 3 years ago

Thanks. By the way, I've read in the media reports that the menubar height for MacBook Pro with notch is higher than usual. Does MenuMeters show correctly? It would be nice if you could post a screenshot.

agraf commented 3 years ago

Menu bar on built-in screen: menubar-builtin

on external screen: menubar-external

As you can see, the same images get used for both, but while the built-in one is higher, the external one kept its height.

yujitach commented 3 years ago

Thanks, very interesting. I wonder if it’s possible to utilize the extra height from menu bar apps…

agraf commented 3 years ago

The screen shots above are from a dual-screen setup where the same bitmaps get displayed on both screens. To support these 2 heights in parallel, the menu bar API would need to render differently per screen/height. I don't believe it does that today, does it?