yukatan / commangular

Command framework for AngularJS
MIT License
83 stars 8 forks source link

Commangular uses reserved keywords #7

Closed sebastian-zarzycki closed 9 years ago

sebastian-zarzycki commented 9 years ago
commangular.create = function(commandName, commandFunction, commandConfig) {
    commands[commandName] = {
        function: commandFunction, // function is reserved keyword
        config: commandConfig,
        interceptors:{},
        commandName:commandName
    };
    commandNameString = commandNameString.concat("%" + commandName + "%{" + commandName + "}\n");
}

It breaks in some browsers (mainly IE). Just change it to commandFunction, I suppose.

yukatan commented 9 years ago

Thanks, I check it out