yuki-kimoto / gitprep

Portable GitHub system into your own server
http://gitprep.yukikimoto.com/
906 stars 118 forks source link

Suggested better setup #186

Open bilogic opened 1 year ago

bilogic commented 1 year ago

Hi,

I think these steps will make it easier to install and upgrade:

  1. rename gitprep.conf as gitprep.conf.example
  2. remove /data folder
  3. Installation should start with git clone https://github.com/yuki-kimoto/gitprep instead of using curl
    git clone https://github.com/yuki-kimoto/gitprep
    cd gitprep
    ./setup_module
  4. If gitprep.conf does not exists, setup_module will create it from gitprep.conf.example
  5. If /data folder does not exists, setup_module or setup_database will create it
  6. To upgrade, just do a git pull in the gitprep folder (which won't overwrite gitprep.conf and /data)

Possible?

yuki-kimoto commented 1 year ago

OK.

yuki-kimoto commented 1 year ago

If /data folder does not exists, setup_module or setup_database will create it

Are you going to choose setup_module or setup_database?

bilogic commented 1 year ago

I haven't look at the code to determine where is the better place. Actually, why is there a need to breakdown into setup_module and setup_database?

yuki-kimoto commented 1 year ago

The reason is that these are different operations.

It is OK that creating the setup script and run setup_module and setup_database in the setup script.

bilogic commented 1 year ago

It is OK that creating the C script and run C and C in the C script.

Yes, I also thought of this, but you are faster haha.

let's call it setup

  1. Create gitprep.conf if not exists
  2. Create /data if not exists
  3. run setup_module
  4. run setup_database

How about that?

yuki-kimoto commented 1 year ago

Almost OK.

How about doing the following?

  1. run setup_module
  2. Create gitprep.conf if not exists
  3. run setup_database(Create /data if not exists)
bilogic commented 1 year ago

Yes, I'm OK, you are the boss :)

yuki-kimoto commented 1 year ago

I can merge this changes if the codes are written.

bilogic commented 1 year ago

OK

Dhsisis commented 1 year ago

/http @Disis PO COMMET blick Tets?

brainchild0 commented 11 months ago

Please consider assigning executable permissions to all setup scripts, including setup, setup_config, and setup_script. Further, please note that the other ones, setup_database and setup_module, are not executable or readable for all users. Please consider setting permissions mode to 0775.

Due especially to calls among various scripts, operation is broken without appropriate permissions.


chmod 755 setup setup_config setup_database setup_module setup_script