search

yuki-zmstr / pe

0 stars 0 forks source link

Missing interface keyword #27

Open yuki-zmstr opened 3 months ago

yuki-zmstr commented 3 months ago

Screenshot 2024-04-19 at 5.46.18 PM.png

In the EconoCraftLogic class diagram, the interface keyword for the Stock interface is missing.

soc-se-bot commented 3 months ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for pointing out the issue! We did not put the interface keyword is due to the plantUML put a circle I representing the interface.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Class Diagram notations not compliant with the notation covered in the course.

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Class diagrams like these should not have the icons like "C", and should not have green circles to denote attribute visibility (should be using - + # etc instead)

image.png

[original: nus-cs2113-AY2324S2/pe-interim#346] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the feedback!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]