search

yuki24 / pushing

Finally, push notification framework that does not hurt. currently supports Android (FCM) and iOS (APNs)
MIT License
46 stars 6 forks source link

apnotic v1.4.1 raise Exception `a block is needed when initializing an Apnotic::ConnectionPool` #20

Closed hase1031 closed 5 years ago

hase1031 commented 6 years ago

Apnotic::ConnectionPool of apnotic v1.4.0 needs some error handler as a block argument. https://github.com/ostinelli/apnotic/pull/70 https://github.com/ostinelli/apnotic/commit/76418499e1052f719d21a419ef0e962d79761f97

yuki24 commented 6 years ago

Yes, this is very important. I'll look to see if exceptions could be thrown properly and handled by Pushing's error handler.

Stylo27 commented 6 years ago

@hase1031 It's message raise because, Apnotic::ConnectionPool require a giving block https://github.com/ostinelli/apnotic/issues/71

yuki24 commented 5 years ago

fixed by 7e245c4.