search

yukiarrr / ios-build-action

Build iOS project (.xcodeproj, .xcworkspace), and export ipa
MIT License
283 stars 139 forks source link

profiles #41

Open sisoje opened 3 years ago

sisoje commented 3 years ago

can you add support for profiles that are pushed to the repo as files?

so instead keeping it a base64 secret, use it as a simple file path.

yukiarrr commented 3 years ago

In order to prevent secret information from being leaked, I am currently not considering supporting anything other than GitHub Actions Secrets (base64).

so instead keeping it a base64 secret, use it as a simple file path.

If you are managing profiles as files, please encode the files before the ios-build-action step.

sisoje commented 3 years ago

I did not say everybody should use profiles as files - it should be an option.

We don't want to encode dosens of files to base64 and put into secrets.

I think it's a simple change to support profile files, isn't it?

yukiarrr commented 3 years ago

OK, I'll consider supporting it at a later date. Of course, PR is welcome!

jaysson commented 3 years ago

https://github.com/marketplace/actions/prepare-signing can download the provisioning profile, which I want to input to this action. This is another valid use case.

yukiarrr commented 3 years ago

@sisoje @jaysson Sorry for the late response. In v1.4.0, it is now possible to specify the path to p12 and mobileprovision.