search

yukiarrr / ios-build-action

Build iOS project (.xcodeproj, .xcworkspace), and export ipa
MIT License
279 stars 135 forks source link

Is it necessary to make the `ios-build` keychain the default keychain? #86

Open starikcetin opened 1 year ago

starikcetin commented 1 year ago

Hello,

After running this action on our self-hosted runners, we noticed the login keychain, which is the existing default, sometimes gets removed. According to https://github.com/fastlane/fastlane/issues/17641#issuecomment-731173383, I suspect this line is the culprit:

https://github.com/yukiarrr/ios-build-action/blob/3d8ff63d40bce5dfd0ff8d1dda6ce543bf4c605a/fastlane/Fastfile#L13

Is that line necessary? Can this action work without replacing the default keychain?

brett-james-rocketlab commented 1 year ago

The default action here makes normal usage of the OS painful as well - you will receive plenty of prompts about wanting to use the keychain - the keychain that you won't be able to unlock because it was created with a random string.

aphillipo commented 1 year ago

Okay, I have fixed this and I also make sure the ios-build.keychain is deleted before each creation: https://github.com/aphillipo/ios-build-action

Feel free to for my fork and reference it - probably not good to use this if you are running in a shared environment as I set the password to the empty string.