yukiarrr / ios-build-action

Build iOS project (.xcodeproj, .xcworkspace), and export ipa
MIT License
279 stars 135 forks source link

Enable custom entitlements #91

Closed proohit closed 1 year ago

proohit commented 1 year ago

Hi,

thanks for your awesome action. I'm trying to build an app using custom Configurations with entitlements in separate files. However, there is no option in the action to configure custom entitlement files. Fastlane supports entitlement files using the entitlements_file_path option in update_code_signing_settings (see http://docs.fastlane.tools/actions/update_code_signing_settings/#parameters).

I don't know if this is the exact attribute to control, but local builds in xCode work with no problems. The custom entitlement files are configured in xcode. How can I pass custom entitlements files to the action in order to be picked up in fastlane?

dasheck0 commented 1 year ago

As far as I can tell this action does not support custom entitlement files. See https://github.com/yukiarrr/ios-build-action/blob/3d8ff63d40bce5dfd0ff8d1dda6ce543bf4c605a/fastlane/Fastfile#L63-L68 There should be an option to provide custom parameters to the update_code_signing_settings function.

Another option is to run resign afterwards (see https://github.com/fastlane/fastlane/issues/17727), but this seems like a hacky workaround.

@yukiarrr Is this repo still maintained?

dasheck0 commented 1 year ago

@yukiarrr Did it myself. See #93. Hope you merge it soon as it is a blocker for us. Let me know if you request some changes. Thanks!

dungi commented 1 year ago

@dasheck0 I guess this feature broke my CI. Cause I have more than 1 entitlement file in my project (Main App, Widgets, WatchApp) the default value ("") would set all paths for the ".envirionment"-File to "", which is currently not what I need. If I set multiple paths, every target gets all 3 entitlements paths set. I need to revert to version 1.5.0