Closed pablovela5620 closed 1 month ago
Attention: Patch coverage is 80.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 90.86%. Comparing base (
f882338
) to head (2a012c1
). Report is 29 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
serde/numpy.py | 73.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @yukinarit,
I've implemented initial support for jaxtyping serialization/deserialization and all tests are passing. Before I proceed with adding specific tests for jaxtyping, could you please review the current implementation and let me know if you're happy with the direction? Any feedback would be greatly appreciated!
Made jaxtyping an optional dep and addressed your typ comment!
Added tests in! Let me know if there's anything else you'd like me to add/fix @yukinarit @kmsquire, otherwise I also think this is probably good to merge
@pablovela5620 Is there anything you want to add before publishing v0.20.0?
Nope, this looks good! Thanks
Jaxtyping serialization/deserializing working along with type checking with beartype #572 . This allows one to use jaxtyping when serializing/deserializing and check both the dtype and the shape. Let me know if this direction makes sense!