search

yukino-org / kazahana-v3

❄️ An extension based Anime & Manga client.
GNU General Public License v3.0
219 stars 29 forks source link

feat: show loading when player is buffering #144

Closed KyleKun closed 3 years ago

KyleKun commented 3 years ago

Hey @zyrouge !

This PR adds:

Btw, I had some issues with recent translations changes but I managed to fix it for running locally (I am not pushing these translation changes since I just wanted to check this buffering feature). Maybe we could use intl to facilitate things a little bit?

Let me know what you think. Thank you!

zyrouge commented 3 years ago

Merging this now, lemme know whats the issue with translations.

KyleKun commented 3 years ago

Several places where trying to access .name the linter complains and it won't build... I replaced it by .language and .country but then the first RegExp would fail the first time in a null check, it worked after setting to english by default and then reading it from storage next time again...

About intl, I think we wouldn't need to restart the app when changing locale then.

zyrouge commented 3 years ago

Several places where trying to access .name the linter complains and it won't build... I replaced it by .language and .country but then the first RegExp would fail the first time in a null check, it worked after setting to english by default and then reading it from storage next time again...

About intl, I think we wouldn't need to restart the app when changing locale then.

Pretty sure the .name is caused by older version of dart. Could use intl, but thats comes with the cause of refactoring lot of code, if there is a way to rebuild the whole MaterialApp widget completely, then we won't be needing to restart the app. (I've tried changing key, wrapping the whole app within a StatefulWidget and use setState to rebuild and marking as needs build way but none of them seem to rebuild everything but only some parts of the widgets)