Closed Quantum-Pi closed 1 week ago
Thanks for your report
convertToGOODStatKey is only designed for artifact stats https://frzyc.github.io/genshin-optimizer/#/doc/StatKey (and I don't know what to name it)
Ah, I see the distinction more clearly now. Forgot flat atk doesn't factor into base atk. Thanks!
Using the following code:
Results in:
(for XQ)
In the linked file, the map contains
FIGHT_PROP_HP/ATTACK/DEFENSE
butgetCharactersById().getStats()
is returningFIGHT_PROP_BASE_HP/ATTACK/DEFENSE
.https://github.com/yuko1101/enka-network-api/blob/a91b4911e483befc450c005a2ab0385867181a6c/src/models/good/IGOODResolvable.ts#L25
I haven't investigated the underlying reason for this and for now I'm manually replacing '_BASE' from the FightProps I'm receiving. From what it looks like though the FightProp type does indeed include the
_BASE
portion. Just wanted to bring it to your attention.