yuku / textcomplete

Autocomplete for HTMLTextAreaElement and more.
https://yuku.takahashi.coffee/textcomplete/
MIT License
1.74k stars 305 forks source link

Fix StrategyProps interface #328

Closed aki77 closed 4 years ago

aki77 commented 4 years ago

If the default value of generics is unknown, the problem is as follows.

https://www.typescriptlang.org/play?#code/C4TwDgpgBAyhCGAnAxgCwMLwDZYEb2QGsAeAFQD4oBeKACkQgGcBXLYRgLilIG0BdAJTVKANwD2ASwAmAKFCQoAJQhgsBCMpZtqUHo2CIJAOwDmAGij7DpvlAA+lg8ZP2oR1lhkzjwCIgBm6rAG8L4mIAAKiGJgjGQ6zEaERmIA7kaUAN4yUFAAtqFoXMomAKIAHmCutPQQJhCVXFbOriUVYEJUlG2VALKFqACCiIjwIK7uOAI5lggoqFy0M7m+iHlNTqZmy1DI2HgEhFxwSGiYOPhEZOTbubkFwEVKde39j0MjYzOdopKyuQxVOpFlJQvAuKQfs8gcgNExWMAZns0BAAPxcXBiMRYBBGJFiIy+crAdF0InADbWExQ5qmVyY7G4ma+PJA3yk2ig4Dg7gWVbrRxUmmbEwzYxSBqk9x5XB+MVSUm00UAXy8yAJ+kFzhgITCIGOurqkWisWISsoNGyd3yA0WUMmWFud0YcyetF88DyFj2F0OUMSEv8xggUidAJUalhILBUIA5LHtqqZOqjJrpbLEDrRnqDdmjVEYnF034LVArXcHm77R4w7NTgsyQgvbt9pdCP6jIHg6GdoDIxBo9y4wmZEmU5qrKE6hImLmp+EC7F+Do9CKs-OQBZi5nDeE+EA

Specifically, the following code will cause an TS2322 error.

const stringStrategy: StrategyProps<string> = {
    match: () => null,
    search: (team, callback) => undefined,
    replace: (data) => '',
}

const textcomplete = new Textcomplete(editor, [stringStrategy], option)
aki77 commented 4 years ago

Thanks!

yuku commented 4 years ago

v0.1.5 was released