Replace only needed range in CodeMirror

yuku / textcomplete

Autocomplete for HTMLTextAreaElement and more.

https://yuku.takahashi.coffee/textcomplete/

MIT License

1.74k stars 305 forks source link

Closed phigasui closed 2 years ago

phigasui commented 3 years ago

Added a method to SearchResult class to provide replacement data.
Using the above method, replace only needed range in CodeMirror.
In order not to change the interface of the SearchResult#replace, the information needed for replacement can be obtained with getReplacementData, which is used in SearchResult#replace and @textcomplete/codemirror.

phigasui commented 2 years ago

@yuku Please review this PR :pray::pray:

yuku commented 2 years ago

@phigasui The failing lint issue was fixed in #348. Could you merge the change to the branch so that we can figure out that CI is green here?

phigasui commented 2 years ago

@yuku Thanks for the fix Lint! I merged the changes, please run CI. :pray:

yuku commented 2 years ago

@phigasui please check the lint errors reported by CI. FYI: you can use yarn workspaces run format to apply prettier.

phigasui commented 2 years ago

@yuku I found a problem in the changes and fixed it, so please review again:pray:

yuku commented 2 years ago

v0.1.10 was released

phigasui commented 2 years ago

Thank you very much!