search

yuku / textcomplete

Autocomplete for HTMLTextAreaElement and more.
https://yuku.takahashi.coffee/textcomplete/
MIT License
1.74k stars 305 forks source link

Support CodeMirror 6 #351

Closed ohakutsu closed 2 years ago

ohakutsu commented 2 years ago

CodeMirror 6 is currently in beta release. https://codemirror.net/6/ https://github.com/codemirror/codemirror.next

The interface has changed in CodeMirror 6. Therefore, @textcomplete/codemirror don't work with CodeMirror 6.

ohakutsu commented 2 years ago

@yuku I plan to implement CodeMirror 6 support and send a Pull Request. However, since CodeMirror 6 is still in beta, I'm hesitant to include it in @textcomplete/codemirror. So I'm considering creating @textcomplete/codemirror-next package.

If you have any ideas, please let me know.

yuku commented 2 years ago

Hi, thanks for considering to contribute to this project.

I think you should create a new repository and publish it as your own npm package such as textcomplete-codemirror-6. In this way, you can completely control your code so it's much easier to develop. As you know, textcomplete/core doesn't care where an editor is defined, as long as it implements the Editor class correctly.

I'm fine to add a link referencing the repository to the README.

ohakutsu commented 2 years ago

@yuku Thanks for the reply. We'll consider publishing the npm package ourselves.

Thank you so much!