search

yuku / textcomplete

Autocomplete for HTMLTextAreaElement and more.
https://yuku.takahashi.coffee/textcomplete/
MIT License
1.74k stars 305 forks source link

Mobile touch event is missed in new update #353

Open MaxLeiter opened 2 years ago

MaxLeiter commented 2 years ago

350 broke using mobile to interact with the autocomplete. Downgrading to 0.1.10 fixed it for me.

yuku commented 2 years ago

Thanks for reporting the issue.

@aki77 (as the author of #350) Are you experiencing similar problems on your site?

MaxLeiter commented 2 years ago

click only fires with a mouse or pointer like device, so it's definitely the culprit.

aki77 commented 2 years ago

The click event also trigger on mobile devices. https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event

It works fine in my environment. This is a screencast confirmed to work on iOS devices in BrowserStack.

aki77 commented 2 years ago

@MaxLeiter Can you provide a minimal reproduction?

fabianeichfeldt commented 2 years ago

I have the same issue even on a desktop app. (Chrome version 103) I am using textcomplete inside a vue.js app and mouse click is not working anymore since version 0.1.11 comparing version 0.1.10 and 0.1.11 https://github.com/yuku/textcomplete/compare/v0.1.10...v0.1.11 looks like mouse down event was better, at least for my environment. But I do not understand why click is not working for me. Even the event is not catched by Dropdown in my environment