Acylation
commented
1 year ago Sorry for the delay upon my declaration, the API is confusing. Here's the explanation of the second change.
This is also related to the boundary case, that multiple tabs sharing the same file. In this case, when one tab calls save(), the
_check flag in setViewData() of other tabs will be false. So through wrapping render KetcherReact, we can retain the editor, and just refresh the data.
With this specific case I found another problem. If we assign the view data through ketcher.setMolecule(), and the undo operation would just revert what the funcion did.
When we have two tabs, drawing on Tab A and updating Tab B automatically, the undo stack of Tab B behaves weird. For obsidian-ketcher v0.1.2, after refreshing the editor, undo will leave a blank canvas on Tab B, because we re-render the editor, and then assign the data value to the tab. For the proposed change, undo will revert save() operation, and we will get the previous state since we retained the editor and pervious data.
If there's a way to interact with the undo stack of ketcher editor, we can even keep it on the page (init in the constructor of KetView), and just update the data. (Update: code here https://github.com/Acylation/obsidian-ketcher/tree/single-editor-instance)
Closes #2
Changes
KetcherReactinsetViewData(), 6da45a3onClose(), 17ecb34Boundary case
If we have multiple tabs holding the same file, on proposed, these tabs will each have an interval, and they will run together, calling
save()more frequently then expected.Notice that, the
setViewData()function would only be called bysave()if there's any change on file data, and the user may probably can't operate multiple editors at the same time, so here's what we'll get:Tab A (changed) | Tab B→save()by Tab A →setViewData()called →Tab A (changed) | Tab B (changed)Tab A (changed) | Tab B→save()by Tab B →setViewData()won't be called →Tab A (changed) | Tab B->save()by Tab A ...And that's a pseudo-sync maybe.