Open muddi900 opened 1 year ago
Thank you for contributing! How did you find the project? I'll check this out and merge this weekend!
I'd also like to add a test for this function, as we are aiming to increase test coverage across the project
I found it searching for issues in GitHub.
On Sun, Jan 8, 2023, 12:42 AM Alex Yule @.***> wrote:
Thank you for contributing! How did you find the project? I'll check this out and merge this weekend!
— Reply to this email directly, view it on GitHub https://github.com/yuletide/nitterbot/pull/12#issuecomment-1374588053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2VVZXNTGKGYKICIIYOCITWRHBIVANCNFSM6AAAAAATOY6QRE . You are receiving this because you authored the thread.Message ID: @.***>
Great, thanks! One thing we need to do here is expand the tests, I'm also working on a rewrite but will try to take a look this week
So do you want the tests to be part of this PR?
On Tue, Jan 24, 2023 at 1:46 AM Alex Yule @.***> wrote:
Great, thanks! One thing we need to do here is expand the tests, I'm also working on a rewrite but will try to take a look this week
— Reply to this email directly, view it on GitHub https://github.com/yuletide/nitterbot/pull/12#issuecomment-1400956642, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2VVZTVUPGCJNE773WZVVTWT3UZHANCNFSM6AAAAAATOY6QRE . You are receiving this because you authored the thread.Message ID: @.***>
@muddi900 if you dont mind adding additional tests for this functionality that would be great, I'm trying to only add new code that is tested to help with the major refactor that will happen eventually
I have added the link parser to the
HTMLFilter
class. The out of theconvert_html__to_text
out puts the expanded links.The tests are passing