yuliskov / LeanKeyboard

Keyboard for Android TV devices (set-top-boxes, TVs etc)
https://www.patreon.com/yuliskov
GNU General Public License v3.0
185 stars 49 forks source link

Swedish Language Support #4

Closed Badkruka closed 6 years ago

Badkruka commented 6 years ago

Hello! I would realy love if you add support for a Swedish keyboard. This app works realy well on Nvidia Shield but I am forced to use English since there is no support for Swedish.

marvinorman commented 6 years ago

I second this. Please add a Swedish language pack!

yuliskov commented 6 years ago

Many thanks. I'll try to add Swedish ASAP.

Badkruka commented 6 years ago

Thanks alot. :D

marvinorman commented 6 years ago

Yuliskov, how can I contact you? I can contribute

yuliskov commented 6 years ago

@marvinorman we could discuss details here in this thread

marvinorman commented 6 years ago

@yuliskov i need to send you some pictures on how leankey should look with swedish language

yuliskov commented 6 years ago

@marvinorman hmm, I don't see a problem. Images could be attached along with the post.

marvinorman commented 6 years ago

leankey1 leankey2

@yuliskov Hope these pictures help with implementing a Swedish language pack. These pictures are from an Android TV box that automatically applies swedish language to Leankey based on system language. But Mi Box 3 and Nvidia Shield doesn't support this. That's why we need external language pack.

yuliskov commented 6 years ago

@marvinorman thanks for the helpful info

yuliskov commented 6 years ago

Seems, done. Caution: since this kbd has different package name, you need to remove any GPlay release of this app first.

https://github.com/yuliskov/LeanKeyKeyboard/releases/download/4.3.14/LeanKeyKeyboardPro_v4.3.14_r.apk

marvinorman commented 6 years ago

@yuliskov Wow, works flawlessly. Thanks alot man!

The only thing i can see is that the "Search" button to the right of the keyboard was automatically translated to swedish with the google play version. But with this apk it says "Search" in english and doesn't translate.

Also, keyboard is defaulting to English language after reboot, and i have to manually switch to Swedish.

Device: Mi Box 3

But other than these two small things, everything is awesome. Thanks again!

Badkruka commented 6 years ago

Thanks for the fast respond. :) I made a clean install with the apk above on my Nvidia Shield TV and at first it seemed to be fine. The virtual keyboard on my TV was a Swedish one and it worked as intended but when I wrote on my physical keyboard it was the english version. My Nvidia Shield are using Android TV 7.0

yuliskov commented 6 years ago

Update. Changes:

marvinorman commented 6 years ago

@yuliskov I uninstalled v. 4.3.14 and installed this, but now i'm only getting English language with this latest apk, anything im doing wrong?

Badkruka commented 6 years ago

Same here. I now only have english keyboard on both virtual and the physical.

yuliskov commented 6 years ago

@marvinorman @Badkruka Thanks for the quick feedback. Language dialog seems working now. https://github.com/yuliskov/LeanKeyKeyboard/releases/download/4.3.17/LeanKeyKeyboardPro_v4.3.17_r.apk

yuliskov commented 6 years ago

Just in case someone want to fully localize keyboard to Swedish. Below the link to the translatable strings. https://github.com/yuliskov/LeanKeyKeyboard/blob/master/leankeykeyboard/src/main/res/values/strings.xml

marvinorman commented 6 years ago

@yuliskov I can translate the strings for you, if you can implement them in the swedish kbd.

Badkruka commented 6 years ago

Thanks for the fast followups. :) I have installed 4.3.17 now and the virtual keyboard works as intended and it still remains Swedish after I reboot. :) But when I write on my physical keyboard it is still the English keyboard.

yuliskov commented 6 years ago

@marvinorman oops, wait a second. I just extracted translation from the Nexus Player's build-in keyboard. I'll do the update in a minute.

yuliskov commented 6 years ago

New release.

https://github.com/yuliskov/LeanKeyKeyboard/releases/download/4.3.18/LeanKeyKeyboardPro_v4.3.18_r.apk

yuliskov commented 6 years ago

But when I write on my physical keyboard it is still the English keyboard.

I wonder.... Is there any virtual keyboard that could do this. I can't find any guide.

marvinorman commented 6 years ago

@yuliskov I decompiled the latest apk and translated the strings to Swedish. Everything works on point.

strings.zip

yuliskov commented 6 years ago

@marvinorman good work. Thank you very much.

yuliskov commented 6 years ago

@marvinorman thanks for the support. Swedish translation has been updated according to the your data. https://github.com/yuliskov/LeanKeyKeyboard/releases/download/4.3.19/LeanKeyKeyboardPro_v4.3.19_r.apk

marvinorman commented 6 years ago

@yuliskov I missed some buttons/text translations with previous strings file. I will upload the final one which is 100% everything correctly translated to Swedish. Strings (Swedish) (Final).zip

yuliskov commented 6 years ago

@marvinorman done https://github.com/yuliskov/LeanKeyKeyboard/releases/download/4.3.20/LeanKeyKeyboardPro_v4.3.20_r.apk

marvinorman commented 6 years ago

@yuliskov Awesome, thanks for all your work!!

yuliskov commented 6 years ago

@Badkruka @marvinorman thanks for the support!

Badkruka commented 6 years ago

I am sorry to say that I still have the english version when I type on my physical keyboard. The virtual one on my screen are the Swedish version but my physical are English. I discovered that Nvidia Shield have your US version installed by default. I could not uninstall it so I dissabled it but it didn't solve the problem. Can that interfer with v4.3.20_r.apk? I have a screenshot of the app info. 20180719_000940 Nvidia Shield are using Android 8.0 Oreo if that can be of use and I am usning this keyboard. https://www.logitech.com/en-us/product/wireless-touch-keyboard-k400-plus

yuliskov commented 6 years ago

@Badkruka my kbd can't control physical kbd at all. I need to significantly rewrite the code to achieve this.

Badkruka commented 6 years ago

Oh ok I didn't know that. Well thanks for the virtual one, it is realy nice and once again thanks for the time you spend giving us a Swedish translation. :D

yuliskov commented 6 years ago

@Badkruka speaking about physical keyboard. I seem found a way to accomplish what you want. There is a project called External Keyboard Helper (link below). Description says that it can change physical keyboard's layouts on-fly by shortcuts. But there is a problem. I can't get it worked. Maybe you'll have more luck.

Direct link to apk: https://drive.google.com/uc?id=1uYBt3Fjyn-PGAo9O6BwgpErSOO32Zg7a GPlay; https://play.google.com/store/apps/details?id=com.apedroid.hwkeyboardhelperdemo