search

yuliskov / SmartTube

SmartTube - an advanced player for set-top boxes and tvs running Android OS
https://www.patreon.com/smarttube
Other
19.18k stars 1.06k forks source link

[Feature request] Create and submit SponsorBlock segments during playback #1597

Open Danny-Alexander opened 2 years ago

Danny-Alexander commented 2 years ago

It would be great if there was basic functionality for creating & submitting segments to SponsorBlock database for videos not already in it so ads etc can be skipped for the next person to watch it.

The SponsorBlock browser extensions do this by adding buttons to the YouTube player so that you can specify the start and end of segments while watching it:

SponsorBlock buttons

When you hit 'Submit Segments' they display a menu to specify the types of the segments you made (into, joke, sponsor etc) and some other details:

SponsorBlock submit segments SponsorBlock submit segments - select segement category

I don't think Preview, Inspect and Edit would be necessary to just create and submit segments.

A way to accurately find the start & end of segments would also be required for SmartTubeNext I think, perhaps some new stepping buttons and/or a togglable mode to temporarily make the forward/back increment very small e.g 0.1s or 1 frame.

Really it's just the basic ability to create and submit segment info that I'm looking for, not all the extra stuff the extensions do like up/down voting segments etc.

Links SponsorBlock API - to create segment(s) SponsorBlock browser extensions - adds this functionality to YouTube player (and more)

netahoy commented 2 years ago

Wouldn't that be a little too much to expect on a TV and from the small remote. Though it would be nice if our old smart TV's are able to help the community in whatever possible way, but than without compromising the UI or maintaing the simplicity of the app.

Danny-Alexander commented 2 years ago

To add all the functionality of the extension (shown in screenshots) would be a lot I think, but I'm not suggesting that.

Just 2 things really:

  1. Mark segments (start+end point) while watching vid
  2. Specify segment types and submit

I'd suggest 1 new always-visible button: 'SponsorBlock create' mode to show/hide other additional buttons needed to mark segments so UI wasn't cluttered unnecessarily.

I expect specifying segment type could be done by defining new a nested menu like quality selection - using existing UI features. This is only done once when you're done watching.

I imagine starting play from a timestamp to preview segment would be straightforward.

Submitting the new sponsorblock info is just sending different text using the API already used and can be stuck in the menu too.

I don't see any part of that that would be too much for smart tv or small remote.

Did you have any specific parts of the process in mind that couldn't be done effectively with existing UI behavior and app functionality?

Danny-Alexander commented 2 years ago

About compromising simplicity, maybe the ability to create sponsorblock could be an option which is off by default so UI would only be different for people wanting to contribute.

netahoy commented 2 years ago

Yea agree with that, which by default would off, hidden away in advance settings.... but the dev needs to work a lot here....