yuliskov / SmartTube

SmartTube - an advanced player for set-top boxes and tvs running Android OS
https://www.patreon.com/smarttube
Other
19.04k stars 1.06k forks source link

[Regression] Short videos stopped showing in "Subscriptions" section #2731

Open marogo2310 opened 1 year ago

marogo2310 commented 1 year ago

Version STN is 18.52. I have unchecked all options "hide" for short videos. Checking and unchecking these options again did not fix the problem.

marogo2310 commented 1 year ago

The same problem is in "Channel" section.

obsydion commented 1 year ago

I have the same problem.

Nethanswarm commented 1 year ago

As I said on another ticket with the same issue, I also have the problem. Though I think I can still find them under channel, which is odd if some people don't even have that, weird.

Edit: By the way, a question for OP, I tried googling it, but what does the use of the word "regression" in square brackets mean in the title?

marogo2310 commented 1 year ago

@Nethanswarm, for me access to short movies is also possible if I start play a some movie, and then go to the channel through the player menu. When I go to a some channel through the Channels section, then I also do not have access to short videos as in the Subscriptions section.

The word [regression] means that the described functionality worked correctly in the past, and now it does not work. Software regression in Wiki

Nethanswarm commented 1 year ago

@marogo2310 Thanks for informing me, I learnt something new!

On the issue, on the beta there is now a shorts section, but it seems to be a mix of shorts from channels I am subscribed to and ones I am not. It would be nice to have an option in settings to only show shorts from subscribed channels.

marogo2310 commented 1 year ago

On the issue, on the beta there is now a shorts section, but it seems to be a mix of shorts from channels I am subscribed to and ones I am not. It would be nice to have an option in settings to only show shorts from subscribed channels.

Yesss, that's exactly what I expect too.😊

vquesnay commented 1 year ago

I have the same issue here. I've the last beta version. I've tried to check all the boxes, stop the application (no short visible as expected), then uncheck all the boxes, restart the app but still no short were visible.

Nethanswarm commented 1 year ago

Hi again, I saw an update on the beta where it said there was a fix to shorts in subscriptions. That's great if this issue is fixed. However is it meant to only apply to any shorts posted by channels you are subscribed to AFTER the update? Cos I checked in the channel section one of the channels I am subscribed to that posts shorts, and there was a short there from 1 day ago, but when I go in the subscriptions section, it is still not there. Just wondering.

Nethanswarm commented 1 year ago

OK, so it is still not adding shorts to subscriptions. Not sure what that update that said it was doing something with shorts and subscriptions did, but I haven't noticed any difference. Is it fixed for other people?

vquesnay commented 1 year ago

For me, the behavior is quite strange : in the short section, the first 2 lines now contains last shorts from channel where I have a subscription. After those 2 lines, the shorts come from a lot of different channels (some I know, some not)

Wolsey20 commented 10 months ago

Still no short videos in the subscriptions section with version 19.81.

Nethanswarm commented 10 months ago

Hi again, just saw an update on the beta about more places to hide shorts from, that's cool, but what about this issue, not being able to have the shorts from subscribed channels as part of the list of videos from subscribed channels.

Nethanswarm commented 8 months ago

Update: I see another update about hiding shorts but nothing about seeing ones you want to see. Do most people just hate shorts and I'm just weird for wanting to actually see ones from subscribed channels?

Nethanswarm commented 3 weeks ago

Saw "Shorts fix" in update changelog. But it doesn't seem to be this issue. Don't suppose it might mean this issue might get worked on soon?

Nethanswarm commented 1 week ago

OK wow. I'm not sure it was intentional, but your latest update on the beta has added a solution to this, albeit in the form of a workaround (which is partly why I think it might not have been intentional). The ability to create groups for channels you are subscribed to is what has allowed this.

Now I know it is there for people who want sub sections of the channels there are subscribed to, but, since, when a channel is added to one, it seems to get the videos from the videos shown under that channel in the channel list, not from the subscriptions section, and as such the shorts are included, what you can do (and I have done), is use this new ability to create a group and then add every channel you are subscribed to to it, which then creates a group which has all the videos from channels you are subscribed to in one place, INCLUDING THE SHORTS. 😀 Thus fixing this problem.

As such, even if it wasn't intentional, thank you very very much. But since it might not be intentional, I want to add, since you have now fixed this, after well over a year of it being broken, please please please don't break it again. Even if you get comments from people saying something along the lines of "Well I like this new feature of being able to divide my subscriptions into smaller groups but I don't want to see the shorts from those channels when I do so.", wait until you have the time to add a way for people to choose whether the shorts are included to make any changes to it, not just go with the simpler thing to do that would make those people happy of making it that the shorts are not included and there is no way of choosing to have them included.

At the moment there is now a way to have a full list of videos from channels you are subscribed to with the shorts (the jerry-rigged way this update allows) and without (just the normal subscriptions section). Any future changes should only ever add, or at least keep the same, options, not take away, even if taking away an option might be the easiest way of adding a different option. At least that's what seems right to me. Again thank you for fixing it, even if it wasn't deliberate.