yuliskov / SmartTube

SmartTube - an advanced player for set-top boxes and tvs running Android OS
https://www.patreon.com/smarttube
Other
19.95k stars 1.07k forks source link

Sponsorblock - missing options #385

Open fawzib opened 3 years ago

fawzib commented 3 years ago
  1. It is only blocking sponsors segments and not the other five types you can block from what I can see. Like intros.
  2. It isn't highlighting the section's on the progress bar.
  3. Update settings to enable/disable segments, enable/disable notification
  4. Setting to temporarily disable sponsorblock skip when manually seeking
  5. overhaul confirmation dialog. auto timeout dialog based on (segment length - 3 seconds). Maybe don't skip segments below 3 seconds if the dialog option was chosen.
  6. a way for smoother skips? maybe don't cache skippable sections and cache ahead?
ajayyy commented 3 years ago

https://github.com/yuliskov/MediaServiceCore/commit/70e13005a9bc9ffbd832050049a9a4b0c0e0aa90

finnzz commented 3 years ago

I didn't know this existed until in was introduced to SmartTubeNext, and it's awesome!

I agree with all 4 points, I was about to comment about the fact that seeking is difficult with Sponsor block on.

The only other thing that I would suggest is that if SponserBlock is enabled in the settings, that a disable check box be added to the player, so that is not necessary to exit the video if for some reason we want to view the sponser blocked content.

cantunborn commented 3 years ago

There is also no notification setting for individual segments, for ex. it is not possible to set manual skip for intro and auto skip for sponsors like in sponsorblock.

SnoFox commented 3 years ago

Thank you for adding SponsorBlock to SmartTubeNext!

Another option to help bring this integration into feature parity with the browser extensions, which I'd appreciate, is whitelisting certain channels.

DraconicNEO commented 3 years ago

This is definitely a problem as it almost undermines the purpose of sponsorblock, I can understand why you wouldn't want people submitting segments on android TV but preventing people from using it for skipping intros or setting a manual skip isn't something that would cause problems on Android TV.

finnzz commented 3 years ago

preventing people from using it for skipping intros or setting a manual skip isn't something that would cause problems on Android TV.

These changes were already implemented a few releases ago. Check settings / sponsorblock / categories (sponsor, intro, credits, self-promotion etc).

There is also the option to get a confirmation dialog before skipping under notification type.

fawzib commented 3 years ago

i updated this topic with new feature requests

finnzz commented 3 years ago

i updated this topic with new feature requests

I will close my thread /bug report on Sponsorblock if you can add it to your list. SponsorBlock is frequently triggered during live streams. Since it's impossible to skip ahead in a live stream, it causes the video to continously attempt skipping, making the video hang.

In a nutshell, don't apply SpondorBlock to live streams, it serves no purpose and frequently leads to playback problems

albino1 commented 3 years ago

I would like to throw another small feature request / fix on the list.

Sometimes it pops up the skip notification for things as short as just a quick dip to black. In the case of extremely short 1-5 second segments labeled by SponsorBlock, it would be great if the the notification disappeared after the "skip to" ending time of the sponsored content. Similarly, if you're already past the ending time of the sponsored content, then pressing skip should just clear the notification, and not jump backwards in time to "the end" of the content.

Thanks for adding SponsorBlock, it's really great.

Edit: Re-reading, I now see that both Option 5 listed above and feature request https://github.com/yuliskov/SmartTubeNext/issues/443 would also solve the problem in probably an easier way.

DraconicNEO commented 3 years ago

I would just like to state that there is no way to make it so that you can automatically skip some sections and Manually skip others. You can only Set global options for skipping and it applies to all sections you have selected to activate.

fawzib commented 3 years ago

@DraconicNEO when you manually seek to a section that is skippable it should bypass the sponsorblock and allow that section to be played. With this logic in mind it should be doable.

DraconicNEO commented 3 years ago

@DraconicNEO when you manually seek to a section that is skippable it should bypass the sponsorblock and allow that section to be played. With this logic in mind it should be doable.

I don't really think that's a good solution though, especially for intros which are at the beginning of the video.

Karasuni commented 3 years ago

Vanced has a good implementation of SponsorBlock:

And probably more. It's a good reference implementation

DraconicNEO commented 3 years ago

Vanced has a good implementation of SponsorBlock:

  • You can select default behavior for the various types
  • You can choose to be notified to make an exception of default behavior: skip this time / unskip this time
  • Timeline has colored highlights to show you the sections
  • Seeking to a default skipped section plays the section as normal. It will be less jarring than the current implementation

And probably more. It's a good reference implementation

Why didn't they just do it like that in the first place though? Don't get me wrong it's that they even did it at all, but it definitely should have more options than what it has now.