Open fawzib opened 3 years ago
I didn't know this existed until in was introduced to SmartTubeNext, and it's awesome!
I agree with all 4 points, I was about to comment about the fact that seeking is difficult with Sponsor block on.
The only other thing that I would suggest is that if SponserBlock is enabled in the settings, that a disable check box be added to the player, so that is not necessary to exit the video if for some reason we want to view the sponser blocked content.
There is also no notification setting for individual segments, for ex. it is not possible to set manual skip for intro and auto skip for sponsors like in sponsorblock.
Thank you for adding SponsorBlock to SmartTubeNext!
Another option to help bring this integration into feature parity with the browser extensions, which I'd appreciate, is whitelisting certain channels.
This is definitely a problem as it almost undermines the purpose of sponsorblock, I can understand why you wouldn't want people submitting segments on android TV but preventing people from using it for skipping intros or setting a manual skip isn't something that would cause problems on Android TV.
preventing people from using it for skipping intros or setting a manual skip isn't something that would cause problems on Android TV.
These changes were already implemented a few releases ago. Check settings / sponsorblock / categories (sponsor, intro, credits, self-promotion etc).
There is also the option to get a confirmation dialog before skipping under notification type.
i updated this topic with new feature requests
i updated this topic with new feature requests
I will close my thread /bug report on Sponsorblock if you can add it to your list. SponsorBlock is frequently triggered during live streams. Since it's impossible to skip ahead in a live stream, it causes the video to continously attempt skipping, making the video hang.
In a nutshell, don't apply SpondorBlock to live streams, it serves no purpose and frequently leads to playback problems
I would like to throw another small feature request / fix on the list.
Sometimes it pops up the skip notification for things as short as just a quick dip to black. In the case of extremely short 1-5 second segments labeled by SponsorBlock, it would be great if the the notification disappeared after the "skip to" ending time of the sponsored content. Similarly, if you're already past the ending time of the sponsored content, then pressing skip should just clear the notification, and not jump backwards in time to "the end" of the content.
Thanks for adding SponsorBlock, it's really great.
Edit: Re-reading, I now see that both Option 5 listed above and feature request https://github.com/yuliskov/SmartTubeNext/issues/443 would also solve the problem in probably an easier way.
I would just like to state that there is no way to make it so that you can automatically skip some sections and Manually skip others. You can only Set global options for skipping and it applies to all sections you have selected to activate.
@DraconicNEO when you manually seek to a section that is skippable it should bypass the sponsorblock and allow that section to be played. With this logic in mind it should be doable.
@DraconicNEO when you manually seek to a section that is skippable it should bypass the sponsorblock and allow that section to be played. With this logic in mind it should be doable.
I don't really think that's a good solution though, especially for intros which are at the beginning of the video.
Vanced has a good implementation of SponsorBlock:
And probably more. It's a good reference implementation
Vanced has a good implementation of SponsorBlock:
- You can select default behavior for the various types
- You can choose to be notified to make an exception of default behavior: skip this time / unskip this time
- Timeline has colored highlights to show you the sections
- Seeking to a default skipped section plays the section as normal. It will be less jarring than the current implementation
And probably more. It's a good reference implementation
Why didn't they just do it like that in the first place though? Don't get me wrong it's that they even did it at all, but it definitely should have more options than what it has now.
It is only blocking sponsors segments and not the other five types you can block from what I can see. Like intros.Update settings to enable/disable segments, enable/disable notification